Verbosity of genbki.pl

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Verbosity of genbki.pl
Дата
Msg-id 11103.1523208822@sss.pgh.pa.us
обсуждение исходный текст
Ответы Re: Verbosity of genbki.pl  (Teodor Sigaev <teodor@sigaev.ru>)
Re: Verbosity of genbki.pl  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
(This was discussed in the "way forward on bootstrap data" thread,
but we didn't do anything about it.)

Traditionally genbki.pl has printed "Writing foo" for every file
it writes out.  As of 372728b0d that is a heck of a lot more files
than it once was, so you get this:

$ make -j8 -s
Writing fmgroids.h
Writing fmgrprotos.h
Writing fmgrtab.c
Writing pg_proc_d.h
Writing pg_type_d.h
Writing pg_attribute_d.h
Writing pg_class_d.h
Writing pg_attrdef_d.h
Writing pg_constraint_d.h
Writing pg_inherits_d.h
Writing pg_index_d.h
Writing pg_operator_d.h
Writing pg_opfamily_d.h
Writing pg_opclass_d.h
Writing pg_am_d.h
Writing pg_amop_d.h
Writing pg_amproc_d.h
Writing pg_language_d.h
Writing pg_largeobject_metadata_d.h
Writing pg_largeobject_d.h
Writing pg_aggregate_d.h
Writing pg_statistic_ext_d.h
Writing pg_statistic_d.h
Writing pg_rewrite_d.h
Writing pg_trigger_d.h
Writing pg_event_trigger_d.h
Writing pg_description_d.h
Writing pg_cast_d.h
Writing pg_enum_d.h
Writing pg_namespace_d.h
Writing pg_conversion_d.h
Writing pg_depend_d.h
Writing pg_database_d.h
Writing pg_db_role_setting_d.h
Writing pg_tablespace_d.h
Writing pg_pltemplate_d.h
Writing pg_authid_d.h
Writing pg_auth_members_d.h
Writing pg_shdepend_d.h
Writing pg_shdescription_d.h
Writing pg_ts_config_d.h
Writing pg_ts_config_map_d.h
Writing pg_ts_dict_d.h
Writing pg_ts_parser_d.h
Writing pg_ts_template_d.h
Writing pg_extension_d.h
Writing pg_foreign_data_wrapper_d.h
Writing pg_foreign_server_d.h
Writing pg_user_mapping_d.h
Writing pg_foreign_table_d.h
Writing pg_policy_d.h
Writing pg_replication_origin_d.h
Writing pg_default_acl_d.h
Writing pg_init_privs_d.h
Writing pg_seclabel_d.h
Writing pg_shseclabel_d.h
Writing pg_collation_d.h
Writing pg_partitioned_table_d.h
Writing pg_range_d.h
Writing pg_transform_d.h
Writing pg_sequence_d.h
Writing pg_publication_d.h
Writing pg_publication_rel_d.h
Writing pg_subscription_d.h
Writing pg_subscription_rel_d.h
Writing postgres.bki
Writing schemapg.h
Writing postgres.description
Writing postgres.shdescription
All of PostgreSQL successfully made. Ready to install.

which seems a tad excessive, especially in a -s run.

I think we should drop the per-file notices.  But there are a couple
of alternatives as to what to do exactly:

1. Print nothing at all.  That's more in keeping with our modern
build practices, but maybe it's too big a change?

2. Print just one message like "Generating postgres.bki and related
files", and I guess a second one for fmgroids.h and related files.

I don't have a strong preference.  Opinions?

            regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: WIP: a way forward on bootstrap data
Следующее
От: Teodor Sigaev
Дата:
Сообщение: Re: Verbosity of genbki.pl