> On 7 Jun 2019, at 06:34, Michael Paquier <michael@paquier.xyz> wrote:
> Any objections to something like the attached?
No objections to moving the file per the patch.
While looking at libpq.h I noticed what seems to be a few nitpicks: the GSS
function prototype isn’t using the common format of having a comment specifying
the file it belongs to; ssl_loaded_verify_locations is defined as extern even
though it’s only available under USE_SSL (which works fine since it’s only
accessed under USE_SSL but seems kinda wrong); and FeBeWaitSet is not listed
under the pqcomm.c prototypes like how the extern vars from be-secure.c are.
All of these are in the attached.
cheers ./daniel