Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()
От
Alena Rybakina
Тема
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()
Дата
Msg-id
0468a156-92c4-4b2b-8475-a573bb8691e1@yandex.ru
Ответ на
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() (David Rowley)
Список
Дерево обсуждения
Should consider materializing the cheapest inner path in consider_parallel_nestloop() tender wang <tndrwang@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() tender wang <tndrwang@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Richard Guo <guofenglinux@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Robert Haas <robertmhaas@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() David Rowley <dgrowleyml@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Tender Wang <tndrwang@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Richard Guo <guofenglinux@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() David Rowley <dgrowleyml@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Alena Rybakina <lena.ribackina@yandex.ru>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() tender wang <tndrwang@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() "Andrey M. Borodin" <x4mmm@yandex-team.ru>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Tender Wang <tndrwang@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Tomasz Rybak <tomasz.rybak@post.pl>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Tender Wang <tndrwang@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Richard Guo <guofenglinux@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Tender Wang <tndrwang@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Richard Guo <guofenglinux@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Richard Guo <guofenglinux@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Alexander Lakhin <exclusion@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Richard Guo <guofenglinux@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Richard Guo <guofenglinux@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Alexander Lakhin <exclusion@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Richard Guo <guofenglinux@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Tender Wang <tndrwang@gmail.com>
RE: Should consider materializing the cheapest inner path in consider_parallel_nestloop() "Fujii.Yuki@df.MitsubishiElectric.co.jp" <Fujii.Yuki@df.MitsubishiElectric.co.jp>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Tender Wang <tndrwang@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() "Fujii.Yuki@df.MitsubishiElectric.co.jp" <Fujii.Yuki@df.MitsubishiElectric.co.jp>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() Tender Wang <tndrwang@gmail.com>
Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() tender wang <tndrwang@gmail.com>
Hi!
Thank you for your work on the subject.
I reviewed your patch and found that your commit message does not fully explain your code, in addition, I found several spelling mistakes.
I think it's better to change to:With parallel seqscan, we should consider materializing the cheapest inner path in
case of nested loop if it doesn't contain a unique node or it is unsafe to use it in a subquery.
Besides, I couldn't understand why we again check that material path is safe?
if (matpath != NULL && matpath->parallel_safe)
try_partial_nestloop_path(root, joinrel, outerpath, matpath,
pathkeys, jointype, extra);
-- Regards, Alena Rybakina
В списке pgsql-hackers по дате отправления