Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()

Поиск
Список
Период
Сортировка
От Alena Rybakina
Тема Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()
Дата
Msg-id 0468a156-92c4-4b2b-8475-a573bb8691e1@yandex.ru
обсуждение исходный текст
Ответ на Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()  (David Rowley <dgrowleyml@gmail.com>)
Список pgsql-hackers

Hi!

Thank you for your work on the subject.


I reviewed your patch and found that your commit message does not fully explain your code, in addition, I found several spelling mistakes.

I think it's better to change to:With parallel seqscan, we should consider materializing the cheapest inner path in
case of nested loop if it doesn't contain a unique node or it is unsafe to use it in a subquery.


Besides, I couldn't understand why we again check that material path is safe?

if (matpath != NULL && matpath->parallel_safe)
            try_partial_nestloop_path(root, joinrel, outerpath, matpath,
                                      pathkeys, jointype, extra);

-- 
Regards,
Alena Rybakina

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Vik Fearing
Дата:
Сообщение: Re: run pgindent on a regular basis / scripted manner
Следующее
От: Robert Haas
Дата:
Сообщение: Re: Query execution in Perl TAP tests needs work