> -----Original Message-----
> From: Andreas Pflug [mailto:Andreas.Pflug@web.de]
> Sent: 16 April 2003 22:07
> To: efesar; pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] PGA3 Memory Leaks
>
>
> efesar wrote:
>
> >Andreas,
> >
> >The wxWindows documentation specifically states those
> objects must be
> >deleted.
> >
> >The one line I didn't uncomment was "delete statistics." Since
> >statistics is a wxListCtrl, it probably doesn't need to be deleted.
> >That's why I left it commented. Please test and document.
> It's possible
> >your crash was caused by that.
> >
> >In the meantime, I think the change should stay. IMHO,
> memory leaks are
> >not wastes of time.
> >
> >Dave -- Opinion? I'll leave this one up to you, it that's okay.
> >
> >
> >
> Keith,
>
> I had the crash on delete statistics.
I'm all for fixing memory leaks whereever possible - particularly when
the docs tell us we should delete things. If there is a specific problem
because the docs are wrong, or something doesn't work quite right, then
we can take the time to figure out exactly the problem rather than just
removing blocks of code.
pgAdmin II, particularly the 1.2 release was amazingly (to me at least)
bug free because I took the time to design, plan and write it properly.
You guys are both doing an excellent job of keeping up that tradition
with pgAdmin III so far - Keith because you've auditted code on at least
a couple of occasions to check for leaks and other potential problems,
and Andreas because you've take the time to properly consider the design
and operation of the schema objects which, frankly, I hadn't.
So, let's keep this way of working up and we should have a killer app
that will hopefully end up being bundled with some of the binary
PostgreSQL distributions.
:-)
Regards, Dave.