Re: bulk typos

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: bulk typos
Дата
Msg-id 01de8ba3-7cce-af94-536b-dec3da7c9cdf@iki.fi
обсуждение исходный текст
Ответ на Re: bulk typos  (Justin Pryzby <pryzby@telsasoft.com>)
Ответы Re: bulk typos  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 25/10/2020 21:48, Justin Pryzby wrote:
> On Sat, Mar 31, 2018 at 05:56:40AM -0500, Justin Pryzby wrote:
>> I needed another distraction so bulk-checked for typos, limited to comments in
>> *.[ch].
>>
>> I'm not passionate about this, but it serves the purpose of reducing the
>> overhead of fixing them individually.
> 
> I happened across this old patch, so ran this again to find new typos.

Nice script.

> There's a few that I don't know how best to fix.
> 
> Heikki, do you remember what this means ?
> +++ b/src/backend/catalog/storage.c
> + * NOTE: the list is kept in TopMemoryContext to be sure it won't disappear
> + * unbetimes.  It'd probably be OK to keep it in TopTransactionContext,
> + * but I'm being paranoid.

Heh, even though I was the last one to touch that line according to git 
blame, I just moved it from smgr.c. Looks like Tom wrote it in 2004. I 
guess it means "too early". That would make sense from the context. 
Google only gives a few hits but they seem to agree with "too early". A 
very rare word, for sure. Might be good to change it to "too early", but 
it's not wrong, and the poet in me kind of likes "unbetimes" :-).

- Heikki



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Justin Pryzby
Дата:
Сообщение: Re: bulk typos
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Supporting = operator in gin/gist_trgm_ops