Обсуждение: Conflict in documentation

Поиск
Список
Период
Сортировка

Conflict in documentation

От
PG Doc comments form
Дата:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/18/logical-replication-row-filter.html
Description:

On page

https://www.postgresql.org/docs/current/logical-replication-row-filter.html#LOGICAL-REPLICATION-ROW-FILTER-INITIAL-DATA-SYNC

If the subscription requires copying pre-existing table data and a
publication contains WHERE clauses, only data that satisfies the row filter
expressions is copied to the subscriber.

and

Warning
Because initial data synchronization does not take into account the publish
parameter when copying existing table data, some rows may be copied that
would not be replicated using DML. Refer to Section 29.9.1, and see Section
29.2.2 for examples.

conflict.




Re: Conflict in documentation

От
"David G. Johnston"
Дата:
On Wednesday, March 18, 2026, PG Doc comments form <noreply@postgresql.org> wrote:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/18/logical-replication-row-filter.html
Description:

On page
https://www.postgresql.org/docs/current/logical-replication-row-filter.html#LOGICAL-REPLICATION-ROW-FILTER-INITIAL-DATA-SYNC

If the subscription requires copying pre-existing table data and a
publication contains WHERE clauses, only data that satisfies the row filter
expressions is copied to the subscriber.

and

Warning
Because initial data synchronization does not take into account the publish
parameter when copying existing table data, some rows may be copied that
would not be replicated using DML. Refer to Section 29.9.1, and see Section
29.2.2 for examples.

conflict.


I don’t see a conflict.

But I also don’t really see the point of the warning - at least not with its present wording.  There is the initial state and the change log (DML) and comparing the two in this manner doesn’t make sense.

It’s seems a bit heavy to say: warning - publish does not apply to the initial table sync.  It seems like it could easily just be a note; or removed altogether as we try to avoid documenting what things don’t do.

That all said I’m not planning on trying to push for a change here.

David J.

RE: Conflict in documentation

От
"Blaziak, Sebastian"
Дата:

Hi David

 

The first line states that the initial data copy will _only_ copy filtered / relevant data.

 

While warning, but also elsewhere in the documentation it is stated that initial table _does not_ respect any publish limitations.

 

Hence the conflict.

 

Thx

Seb

 

From: David G. Johnston <david.g.johnston@gmail.com>
Sent: Wednesday, 18 March 2026 15:15
To: Blaziak, Sebastian <sebastian.blaziak@fisglobal.com>; pgsql-docs@lists.postgresql.org
Subject: Re: Conflict in documentation

 

On Wednesday, March 18, 2026, PG Doc comments form <noreply@postgresql.org> wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/18/logical-replication-row-filter.html
Description:

On page
https://www.postgresql.org/docs/current/logical-replication-row-filter.html#LOGICAL-REPLICATION-ROW-FILTER-INITIAL-DATA-SYNC

If the subscription requires copying pre-existing table data and a
publication contains WHERE clauses, only data that satisfies the row filter
expressions is copied to the subscriber.

and

Warning
Because initial data synchronization does not take into account the publish
parameter when copying existing table data, some rows may be copied that
would not be replicated using DML. Refer to Section 29.9.1, and see Section
29.2.2 for examples.

conflict.

 

I don’t see a conflict.

 

But I also don’t really see the point of the warning - at least not with its present wording.  There is the initial state and the change log (DML) and comparing the two in this manner doesn’t make sense.

 

It’s seems a bit heavy to say: warning - publish does not apply to the initial table sync.  It seems like it could easily just be a note; or removed altogether as we try to avoid documenting what things don’t do.

 

That all said I’m not planning on trying to push for a change here.

 

David J.

 

The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.

Re: Conflict in documentation

От
"David G. Johnston"
Дата:


On Wed, Mar 18, 2026, 07:55 Blaziak, Sebastian <sebastian.blaziak@fisglobal.com> wrote:

Hi David

 

The first line states that the initial data copy will _only_ copy filtered / relevant data.

 

While warning, but also elsewhere in the documentation it is stated that initial table _does not_ respect any publish limitations.

 

Hence the conflict.


"publish" is a setting, it is completely orthogonal to the ability to specify a "where" clause.

A where clause is always applied, both for the transfer of the ledger table data and the transfer of journal event data.  The publish setting can only ever apply to the transfer of journal event data by its very nature.

David J.