Обсуждение: LZ4 enabled by default since 7c1849311e49

Поиск
Список
Период
Сортировка

LZ4 enabled by default since 7c1849311e49

От
Michael Paquier
Дата:
Hi all,
(Added in CC buildfarm owners of animals that I know are already
failing.)

Since 7c1849311e49, LZ4 has been enabled by default in the builds on
HEAD.  Like ICU or readline, this can be overridden with the addition
of a --without-lz4 to disable the library.  If possible, I would
recommend adding a package like lz4-devel or equivalent so as builds
are able to work.

Sorry for the inconvenience.

Thanks,
--
Michael

Вложения

Re: LZ4 enabled by default since 7c1849311e49

От
Andrew Dunstan
Дата:
On 2026-03-03 Tu 11:31 PM, Michael Paquier wrote:
> Hi all,
> (Added in CC buildfarm owners of animals that I know are already
> failing.)
>
> Since 7c1849311e49, LZ4 has been enabled by default in the builds on
> HEAD.  Like ICU or readline, this can be overridden with the addition
> of a --without-lz4 to disable the library.  If possible, I would
> recommend adding a package like lz4-devel or equivalent so as builds
> are able to work.
>
> Sorry for the inconvenience.
>


If you're building with meson this probably doesn't matter, because it 
only builds with explicitly enabled options.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




Re: LZ4 enabled by default since 7c1849311e49

От
Michael Paquier
Дата:
On Thu, Mar 05, 2026 at 02:24:32PM -0500, Andrew Dunstan wrote:
> If you're building with meson this probably doesn't matter, because it only
> builds with explicitly enabled options.

FWIW, it's for this exact reason that I enforce all my option switches
to be disabled or enabled in meson, never automatic.  Automatic
enforcement lacks predictibility, especially if a system upgrade has
the idea to break the library detection, because then I would not test
the setup of dependencies I want.
--
Michael

Вложения

Re: LZ4 enabled by default since 7c1849311e49

От
Mark Wong
Дата:
Hi everyone,

On Wed, Mar 04, 2026 at 01:31:31PM +0900, Michael Paquier wrote:
> Hi all,
> (Added in CC buildfarm owners of animals that I know are already
> failing.) 
> 
> Since 7c1849311e49, LZ4 has been enabled by default in the builds on
> HEAD.  Like ICU or readline, this can be overridden with the addition
> of a --without-lz4 to disable the library.  If possible, I would
> recommend adding a package like lz4-devel or equivalent so as builds
> are able to work.
> 
> Sorry for the inconvenience.

I'm a little behind in catching up on email.  Just wanted to say I'm
starting to get lz4 installed...  Will keep you posted.

Regards,
Mark



Re: LZ4 enabled by default since 7c1849311e49

От
Mark Wong
Дата:
On Thu, Mar 12, 2026 at 10:05:42AM -0700, Mark Wong wrote:
> Hi everyone,
> 
> On Wed, Mar 04, 2026 at 01:31:31PM +0900, Michael Paquier wrote:
> > Hi all,
> > (Added in CC buildfarm owners of animals that I know are already
> > failing.) 
> > 
> > Since 7c1849311e49, LZ4 has been enabled by default in the builds on
> > HEAD.  Like ICU or readline, this can be overridden with the addition
> > of a --without-lz4 to disable the library.  If possible, I would
> > recommend adding a package like lz4-devel or equivalent so as builds
> > are able to work.
> > 
> > Sorry for the inconvenience.
> 
> I'm a little behind in catching up on email.  Just wanted to say I'm
> starting to get lz4 installed...  Will keep you posted.

I think have have most, if not all, animals with lz4 packages installed
with lz4 now.  (I've been trying to use Ansible to help, but there are
still a number of systems Ansible isn't able to help me with.)

What feels like the best way to continue at this point?  Does having me
update configs to set --with-lz4 make more sense than changing the
default?

Regards,
Mark



Re: LZ4 enabled by default since 7c1849311e49

От
Michael Paquier
Дата:
On Mon, Mar 16, 2026 at 01:36:21PM -0700, Mark Wong wrote:
> I think have have most, if not all, animals with lz4 packages installed
> with lz4 now.  (I've been trying to use Ansible to help, but there are
> still a number of systems Ansible isn't able to help me with.)

Thanks for that.

> What feels like the best way to continue at this point?  Does having me
> update configs to set --with-lz4 make more sense than changing the
> default?

With LZ4 being the default in TOAST and seeing your fleet of setups, I
would +1 the addition of the switch to provide more coverage in the
buildfarm.
--
Michael

Вложения

Re: LZ4 enabled by default since 7c1849311e49

От
Mark Wong
Дата:
On Tue, Mar 17, 2026 at 06:40:40AM +0900, Michael Paquier wrote:
> On Mon, Mar 16, 2026 at 01:36:21PM -0700, Mark Wong wrote:
> > I think have have most, if not all, animals with lz4 packages installed
> > with lz4 now.  (I've been trying to use Ansible to help, but there are
> > still a number of systems Ansible isn't able to help me with.)
> 
> Thanks for that.
> 
> > What feels like the best way to continue at this point?  Does having me
> > update configs to set --with-lz4 make more sense than changing the
> > default?
> 
> With LZ4 being the default in TOAST and seeing your fleet of setups, I
> would +1 the addition of the switch to provide more coverage in the
> buildfarm.

Short update, I'll start flipping on lz4 switch next week.

I've added the EDB buildfarm alias in case anyone there wanted to do the
same for the set of animals I've set up there.  (FYI I'm no longer with
EDB.)

Regards,
Mark