Обсуждение: pgsql: Remove unneeded defines from pg_config.h.in

Remove unneeded defines from pg_config.h.in

This commit removes HAVE_ATOMIC_H and HAVE_MBARRIER_H from
pg_config.h.in, cleanup that could have been done in 25f36066dd2a.

Author: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/b2c0d0b7-3944-487d-a03d-d155851958ff@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7d854bdc5b72b30ae58041d88c2be509950b99d4

Modified Files
--------------
src/include/pg_config.h.in | 6 ------
1 file changed, 6 deletions(-)

Michael Paquier <michael@paquier.xyz> writes:
> Remove unneeded defines from pg_config.h.in
> This commit removes HAVE_ATOMIC_H and HAVE_MBARRIER_H from
> pg_config.h.in, cleanup that could have been done in 25f36066dd2a.

This patch is not okay.  pg_config.h.in is a generated file and
hand modifications in it will not do.

If we don't need these symbols anymore, the right fix is to remove
the probes for these headers in the autoconf and meson scripts.

            regards, tom lane

On Sun, Jan 04, 2026 at 07:41:23PM -0500, Tom Lane wrote:
> This patch is not okay.  pg_config.h.in is a generated file and
> hand modifications in it will not do.
>
> If we don't need these symbols anymore, the right fix is to remove
> the probes for these headers in the autoconf and meson scripts.

Oops, sorry for the brain fart.  How about the attached?  autoreconf
and autoheader seem to be OK with it.
--
Michael

Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Jan 04, 2026 at 07:41:23PM -0500, Tom Lane wrote:
>> If we don't need these symbols anymore, the right fix is to remove
>> the probes for these headers in the autoconf and meson scripts.

> Oops, sorry for the brain fart.  How about the attached?  autoreconf
> and autoheader seem to be OK with it.

Looks about right to me.

            regards, tom lane

On Sun, Jan 04, 2026 at 08:09:40PM -0500, Tom Lane wrote:
> Looks about right to me.

Thanks, applied now.  And sorry about the noise.
--
Michael

Michael Paquier <michael@paquier.xyz> writes:
> Thanks, applied now.  And sorry about the noise.

Thanks for fixing.

            regards, tom lane