Обсуждение: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs

Поиск
Список
Период
Сортировка

[PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs

От
Dharin Shah
Дата:
Hello,

and this line

- The number of lexemes must be less than 2^64

Docs wrongly claim "lexemes must be < 2^64" but the actual constraint is
1 MB total storage (MAXSTRPOS), and no 2^64 check exists in the code.

From src/include/tsearch/ts_type.h:
    #define MAXSTRPOS ( (1<<20) - 1)   // 1,048,575 bytes

    typedef struct {
        int32  size;     // number of lexemes
        ...
    } TSVectorData;

 The attached patch:
- Removes the incorrect 2^64 claim
- Clarifies this means "distinct lexemes in a single tsvector value"

Thanks,
Dharin
Вложения

Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs

От
Dharin Shah
Дата:
Hello,

Gentle ping on the textsearch docs patch. Happy to address any feedback

Thanks,
Dharin

On Sat, Dec 27, 2025 at 10:09 PM Dharin Shah <dharinshah95@gmail.com> wrote:
Hello,

and this line

- The number of lexemes must be less than 2^64

Docs wrongly claim "lexemes must be < 2^64" but the actual constraint is
1 MB total storage (MAXSTRPOS), and no 2^64 check exists in the code.

From src/include/tsearch/ts_type.h:
    #define MAXSTRPOS ( (1<<20) - 1)   // 1,048,575 bytes

    typedef struct {
        int32  size;     // number of lexemes
        ...
    } TSVectorData;

 The attached patch:
- Removes the incorrect 2^64 claim
- Clarifies this means "distinct lexemes in a single tsvector value"

Thanks,
Dharin

Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs

От
surya poondla
Дата:
Hi Dharin,

I looked at your patch, it looks good.

In the code, I couldn’t find any 2^64 bound on the lexeme count, so removing that makes sense.
The added sentence about distinct lexeme count seems to overlap with the existing description of tsvector limits, so I’m not sure it adds much new information.

-Surya Poondla

Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs

От
Aditya Gollamudi
Дата:
On Fri, Jan 9, 2026 at 2:01 PM surya poondla <suryapoondla4@gmail.com> wrote:
Hi Dharin,

I looked at your patch, it looks good.

In the code, I couldn’t find any 2^64 bound on the lexeme count, so removing that makes sense.
The added sentence about distinct lexeme count seems to overlap with the existing description of tsvector limits, so I’m not sure it adds much new information.

-Surya Poondla

 +1 on this patch, I was also a bit confused on this part of the documentation. All I could conclude was that the number of lexemes in a tsvector was limited by existing tsvector limits. I agree with Surya's comment about the overlap, I think this patch should only remove the line about the 2^64 bound. Patch applies cleanly!

Adi Gollamudi