Обсуждение: Fix typos: 'Bejing' to 'Beijing' in partition regress/docs
Hi hackers, I noticed several occurrences of the misspelled city name 'Bejing' (should be 'Beijing') in our partition regressions and documentation. While these are just in test files and docs, I believe it's worth fixing. Attached is the patch generated with git format-patch. After making the changes, I ran 'make checkworld' and verified all regression tests pass. I'd appreciate any feedback on whether this aligns with our standards for such corrections. Thanks, JiaoShuntian
Вложения
On Thu, 25 Dec 2025 at 10:36, JiaoShuntian <jiaoshuntian@gmail.com> wrote: > > Hi hackers, > > I noticed several occurrences of the misspelled city name 'Bejing' > (should be 'Beijing') in our partition regressions and documentation. > While these are just in test files and docs, I believe it's worth fixing. > > Attached is the patch generated with git format-patch. After making the > changes, I ran 'make checkworld' and verified all regression tests pass. Hi! I applied your patch, and checked if any instance of "Bejing" left. After your patch there is none, that's good. I run regression tests and they are good at this change also. > I'd appreciate any feedback on whether this aligns with our standards > for such corrections. Sure, I think this is no-brainer, LGTM. > Thanks, > JiaoShuntian -- Best regards, Kirill Reshke
> On Dec 25, 2025, at 13:36, JiaoShuntian <jiaoshuntian@gmail.com> wrote: > > Hi hackers, > > I noticed several occurrences of the misspelled city name 'Bejing' (should be 'Beijing') in our partition regressions anddocumentation. While these are just in test files and docs, I believe it's worth fixing. > > Attached is the patch generated with git format-patch. After making the changes, I ran 'make checkworld' and verified allregression tests pass. > > I'd appreciate any feedback on whether this aligns with our standards for such corrections. > > Thanks, > JiaoShuntian<0001-Fix-typos.patch> I just found one more occurrance in doc/src/sgml/ref/alter_table.sgml, you may fix it as well. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
On Thu, 25 Dec 2025 at 11:56, Chao Li <li.evan.chao@gmail.com> wrote: > > > > > On Dec 25, 2025, at 13:36, JiaoShuntian <jiaoshuntian@gmail.com> wrote: > > > > Hi hackers, > > > > I noticed several occurrences of the misspelled city name 'Bejing' (should be 'Beijing') in our partition regressionsand documentation. While these are just in test files and docs, I believe it's worth fixing. > > > > Attached is the patch generated with git format-patch. After making the changes, I ran 'make checkworld' and verifiedall regression tests pass. > > > > I'd appreciate any feedback on whether this aligns with our standards for such corrections. > > > > Thanks, > > JiaoShuntian<0001-Fix-typos.patch> > > I just found one more occurrance in doc/src/sgml/ref/alter_table.sgml, you may fix it as well. > > Best regards, > -- > Chao Li (Evan) > HighGo Software Co., Ltd. > https://www.highgo.com/ > Hi! Where exactly? I do not find any issues in doc/src/sgml/ref/alter_table.sgml after patch applied -- Best regards, Kirill Reshke
> On Dec 25, 2025, at 15:19, Kirill Reshke <reshkekirill@gmail.com> wrote: > > On Thu, 25 Dec 2025 at 11:56, Chao Li <li.evan.chao@gmail.com> wrote: >> >> >> >>> On Dec 25, 2025, at 13:36, JiaoShuntian <jiaoshuntian@gmail.com> wrote: >>> >>> Hi hackers, >>> >>> I noticed several occurrences of the misspelled city name 'Bejing' (should be 'Beijing') in our partition regressionsand documentation. While these are just in test files and docs, I believe it's worth fixing. >>> >>> Attached is the patch generated with git format-patch. After making the changes, I ran 'make checkworld' and verifiedall regression tests pass. >>> >>> I'd appreciate any feedback on whether this aligns with our standards for such corrections. >>> >>> Thanks, >>> JiaoShuntian<0001-Fix-typos.patch> >> >> I just found one more occurrance in doc/src/sgml/ref/alter_table.sgml, you may fix it as well. >> >> Best regards, >> -- >> Chao Li (Evan) >> HighGo Software Co., Ltd. >> https://www.highgo.com/ >> > > Hi! Where exactly? I do not find any issues in > doc/src/sgml/ref/alter_table.sgml after patch applied > Ah… My bad. I incidentally found the occurrence after I switched to the other branch. I confirmed that one has been fixedby the patch. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/