Обсуждение: Fix wrong reference in pg_overexplain's doc

Поиск
Список
Период
Сортировка

Fix wrong reference in pg_overexplain's doc

От
Julien Tachoires
Дата:
Hi,

pg_overexplain's documentation mentions that the definition of
RangeTblEntry is in nodes/plannodes.h, which seems to be wrong as it
is defined in nodes/parsenodes.h. Please find a small patch fixing this.

Regards,

-- 
Julien Tachoires

Вложения

Re: Fix wrong reference in pg_overexplain's doc

От
Shixin Wang
Дата:
LGTM

The RangeTblEntry struct is indeed defined in parsenodes.h, not plannodes.h.
This patch corrects the incorrect reference.
All tests pass with make check-world.

Regards,
Shixin Wang



Re: Fix wrong reference in pg_overexplain's doc

От
Fujii Masao
Дата:
On Thu, Dec 18, 2025 at 6:23 PM Julien Tachoires <julien@tachoires.me> wrote:
>
> Hi,
>
> pg_overexplain's documentation mentions that the definition of
> RangeTblEntry is in nodes/plannodes.h, which seems to be wrong as it
> is defined in nodes/parsenodes.h. Please find a small patch fixing this.

Thanks for the patch! It looks good to me.

Barring any objections, I'll commit it and backpatch to v18,
where pg_overexplain was introduced.

Regards,

--
Fujii Masao