Обсуждение: Avoid use scoped block variable

Hi,

On 2025-12-09 13:06:35 -0300, Ranier Vilela wrote:
> I noticed a possible violation of C rules.
> Some functions rely on local block variables,
> but this are a mistake.
> Once that block exits, the memory of the variable is released.

CStringGetTextDatum() copies its input to a fresh allocation. So there's no
longer-lived references to the local memory, unless I miss something?

Greetings,

Andres Freund

On 12/9/25 17:06, Ranier Vilela wrote:
> Hi.
> 
> I noticed a possible violation of C rules.
> Some functions rely on local block variables, 
> but this are a mistake.
> Once that block exits, the memory of the variable is released.
> 
> Fix by moving the declaration variables.
> 

When you say "possible violation", did you check the issue is real?

All these places call CStringGetTextDatum, which calls cstring_to_text,
which allocates a new varlena copy of the string. So why is this an
issue, exactly?


regards

-- 
Tomas Vondra