Обсуждение: Fix typo 586/686 in atomics/arch-x86.h

Поиск
Список
Период
Сортировка

Fix typo 586/686 in atomics/arch-x86.h

От
Jakub Wartak
Дата:
That's a typo in src/include/port/atomics/arch-x86.h, isn't it ?:
   if defined(__i568__) || defined(__i668__) || /* gcc i586+ */
If yes, then a patch is attached. Not that it harms something or
somebody has such old hardware, but I've just spotted it while looking
for something else.

-J.

Вложения

Re: Fix typo 586/686 in atomics/arch-x86.h

От
Daniel Gustafsson
Дата:
> On 28 Nov 2025, at 09:44, Jakub Wartak <jakub.wartak@enterprisedb.com> wrote:
>
> That's a typo in src/include/port/atomics/arch-x86.h, isn't it ?:
>   if defined(__i568__) || defined(__i668__) || /* gcc i586+ */
> If yes, then a patch is attached. Not that it harms something or
> somebody has such old hardware, but I've just spotted it while looking
> for something else.

That indeed looks like a clear typo, but if noone has complained since 2017
then maybe removing the checks is the right course of action?

--
Daniel Gustafsson