Обсуждение: Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

Поиск
Список
Период
Сортировка

Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

От
Erik Rijkers
Дата:
Op 11/7/25 om 15:27 schreef Daniel Gustafsson:
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f
> 
> Modified Files
> --------------
> doc/src/sgml/ref/pg_dump.sgml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Hi,

In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:

"unless the directory exist and is empty." should be
"unless the directory exists and is empty."

i.e., 'exists': because 'directory' is singular.

Thanks!

Erik




Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

От
Chao Li
Дата:

> On Nov 27, 2025, at 13:48, Erik Rijkers <er@xs4all.nl> wrote:
>
> Op 11/7/25 om 15:27 schreef Daniel Gustafsson:
>> Branch
>> ------
>> master
>> Details
>> -------
>> https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f
>> Modified Files
>> --------------
>> doc/src/sgml/ref/pg_dump.sgml | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Hi,
>
> In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
>
> "unless the directory exist and is empty." should be
> "unless the directory exists and is empty."
>
> i.e., 'exists': because 'directory' is singular.
>

+1, agreed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

От
Michael Paquier
Дата:
On Thu, Nov 27, 2025 at 06:48:56AM +0100, Erik Rijkers wrote:
> In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
>
> "unless the directory exist and is empty." should be
> "unless the directory exists and is empty."
>
> i.e., 'exists': because 'directory' is singular.

Indeed, good catch.  Daniel will very likely show up.  If not, I'll go
apply a fix.
--
Michael

Вложения

Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

От
Daniel Gustafsson
Дата:
> On 27 Nov 2025, at 07:33, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Thu, Nov 27, 2025 at 06:48:56AM +0100, Erik Rijkers wrote:
>> In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
>> 
>> "unless the directory exist and is empty." should be
>> "unless the directory exists and is empty."
>> 
>> i.e., 'exists': because 'directory' is singular.
> 
> Indeed, good catch.  Daniel will very likely show up.  If not, I'll go
> apply a fix.

Done, sorry for the delay.

--
Daniel Gustafsson