Обсуждение: Button alignment on hamburger menu

Поиск
Список
Период
Сортировка

Button alignment on hamburger menu

От
Dave Page
Дата:
When the browser viewport shrinks and switches to hamburger menu mode, the search and light dark mode buttons are terribly aligned.

The attached patch fixes that. See the attached screenshots for before/after.

I will commit on Friday if no-one objects.

--
Вложения

Re: Button alignment on hamburger menu

От
"Jonathan S. Katz"
Дата:
On 11/26/25 5:40 AM, Dave Page wrote:
> When the browser viewport shrinks and switches to hamburger menu mode, 
> the search and light dark mode buttons are terribly aligned.
> 
> The attached patch fixes that. See the attached screenshots for before/ 
> after.
> 
> I will commit on Friday if no-one objects.

My only nit would be to put the code in the section that is entitled

"/* Burger menu */"

just to keep the like CSS together. We spent a lot of time in the 
redesign of 2018 to try to keep the CSS from being strewn all about :)

Thanks,

Jonathan

Вложения

Re: Button alignment on hamburger menu

От
Dave Page
Дата:
Hi

On Thu, 27 Nov 2025 at 16:10, Jonathan S. Katz <jkatz@postgresql.org> wrote:
On 11/26/25 5:40 AM, Dave Page wrote:
> When the browser viewport shrinks and switches to hamburger menu mode,
> the search and light dark mode buttons are terribly aligned.
>
> The attached patch fixes that. See the attached screenshots for before/
> after.
>
> I will commit on Friday if no-one objects.

My only nit would be to put the code in the section that is entitled

"/* Burger menu */"

just to keep the like CSS together. We spent a lot of time in the
redesign of 2018 to try to keep the CSS from being strewn all about :)

Thanks.

I've committed this, with a title of "Hamburger menu" (so both hamburger and burger will match any searches). Note that the position of it within the file is basically fixed as it's within a slightly larger pre-existing @media block. 
 
--

Re: Button alignment on hamburger menu

От
"Jonathan S. Katz"
Дата:
On 11/28/25 4:09 AM, Dave Page wrote:

> I've committed this, with a title of "Hamburger menu" (so both hamburger 
> and burger will match any searches). Note that the position of it within 
> the file is basically fixed as it's within a slightly larger pre- 
> existing @media block.

Ah, I missed that in the diff - thanks!

Jonathan

Вложения