Обсуждение: Rename Contributor to Significant Contributor
Hi, I plan to commit the attached patch to rename Contributor to Significant Contributor. Also included is some copy-editing of the pages. https://www.postgresql.org/about/policies/contributors/: * really needs a "Policy" in the page title or everyone is confused why this page isn't listing people https://www.postgresql.org/community/contributors/ * I added a "PostgreSQL" to the (in-page) title so "PostgreSQL Contributor Profiles" sounds better than a mundane "Contributor Profiles" listing * I moved the "how to suggest" section to the end so the list isn't cluttered with too much text at the top * The sections all have introductory text now (likely needs manual importing of the json file, like the actual "Significant" (and Past Significant Contributor) rename. https://www.postgresql.org/about/governance/contributors/: * add Floor (already pushed in a separate commit) Christoph
> On 24 Nov 2025, at 16:50, Christoph Berg <myon@debian.org> wrote: > I plan to commit the attached patch There is no attached patch.. =) -- Daniel Gustafsson
Re: Daniel Gustafsson > > On 24 Nov 2025, at 16:50, Christoph Berg <myon@debian.org> wrote: > > > I plan to commit the attached patch > > There is no attached patch.. =) Duh! Christoph
Вложения
Hi Christoph, On 11/24/25 10:50 AM, Christoph Berg wrote: > Hi, > > I plan to commit the attached patch to rename Contributor to > Significant Contributor. Also included is some copy-editing of the > pages. Thanks! I reviewed the patch in the downstream attachment. LGTM overall, a few notes: * The fixtures edits will be purely for testing purposes; those changes will need to be added into the "Contributor types" section of the admin panel. * I'd note in the commit message that there are a few other cosmetic changes and list them out. > https://www.postgresql.org/about/policies/contributors/: > > * really needs a "Policy" in the page title or everyone is confused > why this page isn't listing people This is fine. > https://www.postgresql.org/community/contributors/ > * I added a "PostgreSQL" to the (in-page) title so "PostgreSQL > Contributor Profiles" sounds better than a mundane "Contributor > Profiles" listing This is fine; I think it's also OK to add it to the title block, since it'll appear in search results with that too, but I'm not wed to that opinion. > * I moved the "how to suggest" section to the end so the list isn't > cluttered with too much text at the top I'm not sure what the reasoning was to have it originally up top - maybe it was to make it easier to find that info, especially because the page is fairly long. I'd be OK with keeping it up top - it's not too much to scroll. > * The sections all have introductory text now (likely needs manual > importing of the json file, like the actual "Significant" (and Past > Significant Contributor) rename. > > https://www.postgresql.org/about/governance/contributors/: > > * add Floor (already pushed in a separate commit) LGTM. Thanks! Joanthan
Вложения
Re: Jonathan S. Katz > * The fixtures edits will be purely for testing purposes; those changes will > need to be added into the "Contributor types" section of the admin panel. Ah ok. I can see them there, but lack permission to edit. > * I'd note in the commit message that there are a few other cosmetic changes > and list them out. Ok. > > https://www.postgresql.org/community/contributors/ What I forgot to mention is a small detail that is perhaps interesting: I'm changing These are the fine people that make PostgreSQL what it is today! to These are the fine people that made PostgreSQL what it is today! ^ Good/bad? > > * I added a "PostgreSQL" to the (in-page) title so "PostgreSQL > > Contributor Profiles" sounds better than a mundane "Contributor > > Profiles" listing > > This is fine; I think it's also OK to add it to the title block, since it'll > appear in search results with that too, but I'm not wed to that opinion. The current <title> is already "PostgreSQL: Contributor Profiles", so duplicating that is a bit weird. (But having header title and in-page title deviate is also weird...) > > * I moved the "how to suggest" section to the end so the list isn't > > cluttered with too much text at the top > > I'm not sure what the reasoning was to have it originally up top - maybe it > was to make it easier to find that info, especially because the page is > fairly long. I'd be OK with keeping it up top - it's not too much to scroll. IIRC originally there was only some "mail webmaster" bit at the bottom. I think that page has this information: 1. who are the people on the list 2. how do I add someone And currently 2 is before 1, which seems weird to me at least. > LGTM. Thanks! Thanks! Christoph
On 11/24/25 3:52 PM, Christoph Berg wrote: > Re: Jonathan S. Katz >> * The fixtures edits will be purely for testing purposes; those changes will >> need to be added into the "Contributor types" section of the admin panel. > > Ah ok. I can see them there, but lack permission to edit. Ack; when you're ready to push, I can make those changes in the admin (or if simpler, I can also push / change at the same time). >>> https://www.postgresql.org/community/contributors/ > > What I forgot to mention is a small detail that is perhaps > interesting: I'm changing > > These are the fine people that make PostgreSQL what it is today! > > to > > These are the fine people that made PostgreSQL what it is today! > ^ > > Good/bad? This is a fun one :) I liked "make" because it's in present tense, and is true - active contributors continue to make PostgreSQL! >>> * I added a "PostgreSQL" to the (in-page) title so "PostgreSQL >>> Contributor Profiles" sounds better than a mundane "Contributor >>> Profiles" listing >> >> This is fine; I think it's also OK to add it to the title block, since it'll >> appear in search results with that too, but I'm not wed to that opinion. > > The current <title> is already "PostgreSQL: Contributor Profiles", so > duplicating that is a bit weird. (But having header title and in-page > title deviate is also weird...) Ah OK, I'm fine with it as you originally suggested. My search results were hiding the "PostgreSQL" title away. >>> * I moved the "how to suggest" section to the end so the list isn't >>> cluttered with too much text at the top >> >> I'm not sure what the reasoning was to have it originally up top - maybe it >> was to make it easier to find that info, especially because the page is >> fairly long. I'd be OK with keeping it up top - it's not too much to scroll. > > IIRC originally there was only some "mail webmaster" bit at the bottom. > > I think that page has this information: > > 1. who are the people on the list > 2. how do I add someone > > And currently 2 is before 1, which seems weird to me at least. I'm not strongly opinionated on this one, so I'm fine with moving it to the bottom. I think your reasoning makes sense. Thanks, Jonathan
Вложения
Re: Jonathan S. Katz > > Ah ok. I can see them there, but lack permission to edit. > > Ack; when you're ready to push, I can make those changes in the admin (or if > simpler, I can also push / change at the same time). I just pushed the update. Please do the admin interface edits whenever you have time. > This is a fun one :) I liked "make" because it's in present tense, and is > true - active contributors continue to make PostgreSQL! I left that change out for now. In some sense "made" is more accurate because everything contributing to the current state happened in the past (and there are also "Past" contributors on the page), but then "make" perhaps sounds more active. We can still bikeshed it separately :) > > The current <title> is already "PostgreSQL: Contributor Profiles", so > > duplicating that is a bit weird. (But having header title and in-page > > title deviate is also weird...) > > > > * I moved the "how to suggest" section to the end so the list isn't > > > > cluttered with too much text at the top The top of the page looks much nicer now, "PostgreSQL Contributors... here are the names!" with less technical distraction. (Perhaps the "people can update their info" bit should also be moved away.) > I'm not strongly opinionated on this one, so I'm fine with moving it to the > bottom. I think your reasoning makes sense. Thanks for the review! Christoph
On 11/28/25 10:02 AM, Christoph Berg wrote: > Re: Jonathan S. Katz >>> Ah ok. I can see them there, but lack permission to edit. >> >> Ack; when you're ready to push, I can make those changes in the admin (or if >> simpler, I can also push / change at the same time). > > I just pushed the update. Please do the admin interface edits whenever > you have time. Done! Thanks for working on this, Jonathan