Обсуждение: Fix typos in ExecChooseHashTableSize()

Поиск
Список
Период
Сортировка

Fix typos in ExecChooseHashTableSize()

От
Tender Wang
Дата:
Hi,

While stepping into the ExecChooseHashTableSize(),
I found two typos in the comments
One is as follows:
/* Check that buckets wont't overflow MaxAllocSize */
if (nbuckets > (MaxAllocSize / sizeof(HashJoinTuple) / 2))
     break;

The other  one is :

/*
* Check that space_allowed won't overlow SIZE_MAX.
*
* We don't use hash_table_bytes here, because it does not include the
* skew buckets. And we want to limit the overall memory limit.
*/
if ((*space_allowed) > (SIZE_MAX / 2))
    break;

In the first comment,  "wont't" should be "won't".
In the second comment,  "overlow" should be "overflow".
The attached patch fixes these typos.
--
Thanks,
Tender Wang
Вложения

Re: Fix typos in ExecChooseHashTableSize()

От
Richard Guo
Дата:
On Tue, Nov 18, 2025 at 6:30 PM Tender Wang <tndrwang@gmail.com> wrote:
> In the first comment,  "wont't" should be "won't".
> In the second comment,  "overlow" should be "overflow".

The first one was fixed by Álvaro in another commit.  I've just pushed
a fix for the second one.

- Richard



Re: Fix typos in ExecChooseHashTableSize()

От
Tender Wang
Дата:


Richard Guo <guofenglinux@gmail.com> 于2025年11月19日周三 10:18写道:
On Tue, Nov 18, 2025 at 6:30 PM Tender Wang <tndrwang@gmail.com> wrote:
> In the first comment,  "wont't" should be "won't".
> In the second comment,  "overlow" should be "overflow".

The first one was fixed by Álvaro in another commit.  I've just pushed
a fix for the second one.

- Richard

Thanks for pushing.
--
Thanks,
Tender Wang