Обсуждение: doc: Fix missing or duplicate closing parentheses in some documents

Поиск
Список
Период
Сортировка

doc: Fix missing or duplicate closing parentheses in some documents

От
Daisuke Higuchi
Дата:
Hi
I found that the parentheses seemed not to be handled correctly in following 3 documents, so I attach the patch for this.

- closing parentheses is missing
  - doc/src/sgml/client-auth.sgml

- closing parentheses is duplicate
  - doc/src/sgml/ltree.sgml
  - doc/src/sgml/trigger.sgml

Regards
Вложения

Re: doc: Fix missing or duplicate closing parentheses in some documents

От
Erik Wienhold
Дата:
On 2025-11-07 02:40 +0100, Daisuke Higuchi wrote:
> I found that the parentheses seemed not to be handled correctly in
> following 3 documents, so I attach the patch for this.
> 
> - closing parentheses is missing
>   - doc/src/sgml/client-auth.sgml
> 
> - closing parentheses is duplicate
>   - doc/src/sgml/ltree.sgml
>   - doc/src/sgml/trigger.sgml

All three changes make sense.  Although I would rephrase the part in
client-auth.sgml from this:

"a regular expression (when starting with a slash (<literal>/</literal>))"

to this:

"a regular expression starting with a slash (<literal>/</literal>)"

The latter reads nicer IMO and avoids the double closing parenthesis
which I find a bit awkward.

-- 
Erik Wienhold



Re: doc: Fix missing or duplicate closing parentheses in some documents

От
Daisuke Higuchi
Дата:
Thank you for checking!

>"a regular expression (when starting with a slash (<literal>/</literal>))"
>to this:
>"a regular expression starting with a slash (<literal>/</literal>)"

Yes, I agree with you. I also think this is easier to read.

Regards,

2025年11月7日(金) 13:08 Erik Wienhold <ewie@ewie.name>:
On 2025-11-07 02:40 +0100, Daisuke Higuchi wrote:
> I found that the parentheses seemed not to be handled correctly in
> following 3 documents, so I attach the patch for this.
>
> - closing parentheses is missing
>   - doc/src/sgml/client-auth.sgml
>
> - closing parentheses is duplicate
>   - doc/src/sgml/ltree.sgml
>   - doc/src/sgml/trigger.sgml

All three changes make sense.  Although I would rephrase the part in
client-auth.sgml from this:

"a regular expression (when starting with a slash (<literal>/</literal>))"

to this:

"a regular expression starting with a slash (<literal>/</literal>)"

The latter reads nicer IMO and avoids the double closing parenthesis
which I find a bit awkward.

--
Erik Wienhold

Re: doc: Fix missing or duplicate closing parentheses in some documents

От
Bruce Momjian
Дата:
On Fri, Nov  7, 2025 at 01:39:07PM +0900, Daisuke Higuchi wrote:
> Thank you for checking!
> 
> >"a regular expression (when starting with a slash (<literal>/</literal>))"
> >to this:
> >"a regular expression starting with a slash (<literal>/</literal>)"
> 
> Yes, I agree with you. I also think this is easier to read.

Very good, patches applied with adjustment by Erik Wienhold.

---------------------------------------------------------------------------

> 
> Regards,
> 
> 2025年11月7日(金) 13:08 Erik Wienhold <ewie@ewie.name>:
> 
>     On 2025-11-07 02:40 +0100, Daisuke Higuchi wrote:
>     > I found that the parentheses seemed not to be handled correctly in
>     > following 3 documents, so I attach the patch for this.
>     >
>     > - closing parentheses is missing
>     >   - doc/src/sgml/client-auth.sgml
>     >
>     > - closing parentheses is duplicate
>     >   - doc/src/sgml/ltree.sgml
>     >   - doc/src/sgml/trigger.sgml
> 
>     All three changes make sense.  Although I would rephrase the part in
>     client-auth.sgml from this:
> 
>     "a regular expression (when starting with a slash (<literal>/</literal>))"
> 
>     to this:
> 
>     "a regular expression starting with a slash (<literal>/</literal>)"
> 
>     The latter reads nicer IMO and avoids the double closing parenthesis
>     which I find a bit awkward.
> 
>     --
>     Erik Wienhold
> 

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.