Обсуждение: Remove specific _\n code in TAP for Windows

Поиск
Список
Период
Сортировка

Remove specific _\n code in TAP for Windows

От
Michael Paquier
Дата:
Hi all,

$subject has been mentioned by Jacob (in CC.) on Discord, and it does
not seem like somebody took the time to propose a patch.

We use in some places of the TAP tests the following pattern:
my $newline = $windows_os ? "\r\n" : "\n";

Two files have this idea:
- 003_ldap_connection_param_lookup.pl
- 006_service.pl
Note: I have committed one of these.

However, in light of 1c6d4629394d, we should not require that, and the
CI looks happy with the attached.

That would be up to the buildfarm to act as final judge, but any
objections in attempting to get rid of these like in the attached?
I would try first HEAD to be sure, then follow with an optional
backpatch.

Thoughts?
--
Michael

Вложения

Re: Remove specific _\n code in TAP for Windows

От
Daniel Gustafsson
Дата:
> On 24 Oct 2025, at 08:51, Michael Paquier <michael@paquier.xyz> wrote:

> in light of 1c6d4629394d, we should not require that, and the
> CI looks happy with the attached.

+1, a nice win in terms of readability.

--
Daniel Gustafsson