Обсуждение: remove partColsUpdated
This was first added in commit 2f17844 (v11), and AFAICT it was only used for a variable named update_tuple_routing_needed in ExecInitModifyTable(), which was removed by commit c5b7ba4 (v14). Any objections to removing it now? -- nathan
Вложения
> On Oct 15, 2025, at 23:50, Nathan Bossart <nathandbossart@gmail.com> wrote: > > This was first added in commit 2f17844 (v11), and AFAICT it was only used > for a variable named update_tuple_routing_needed in ExecInitModifyTable(), > which was removed by commit c5b7ba4 (v14). Any objections to removing it > now? > > -- > nathan > <v1-0001-remove-partColsUpdated.patch> Looks like this is only one assignment to it and nobody reads it. I don’t see a reason to retain it. Maybe back patch through14? I tried to build, and “make check” with this patch, and everything looks good. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
Chao Li <li.evan.chao@gmail.com> writes: > On Oct 15, 2025, at 23:50, Nathan Bossart <nathandbossart@gmail.com> wrote: >> This was first added in commit 2f17844 (v11), and AFAICT it was only used >> for a variable named update_tuple_routing_needed in ExecInitModifyTable(), >> which was removed by commit c5b7ba4 (v14). Any objections to removing it >> now? > Looks like this is only one assignment to it and nobody reads it. I don’t see a reason to retain it. I just had a look through https://codesearch.debian.net/ and couldn't find any evidence that any extensions are using it, so +1 to remove. > Maybe back patch through 14? Certainly not. That would cause an ABI break for any extension that touches later fields in PlannerInfo or ModifyTable. We don't expect extensions to get recompiled for minor releases. regards, tom lane
On Wed, Oct 15, 2025 at 08:18:41PM -0400, Tom Lane wrote: > Chao Li <li.evan.chao@gmail.com> writes: >> On Oct 15, 2025, at 23:50, Nathan Bossart <nathandbossart@gmail.com> wrote: >>> This was first added in commit 2f17844 (v11), and AFAICT it was only used >>> for a variable named update_tuple_routing_needed in ExecInitModifyTable(), >>> which was removed by commit c5b7ba4 (v14). Any objections to removing it >>> now? > >> Looks like this is only one assignment to it and nobody reads it. I don’t see a reason to retain it. > > I just had a look through https://codesearch.debian.net/ and couldn't > find any evidence that any extensions are using it, so +1 to remove. Yes, that feels OK. I've also spent some time looking at what github is able to refer to, but I can only find traces of forked code or cloned repositories in the open, without specific uses for it. +1. -- Michael