Обсуждение: RE: Patch for migration of the pg_commit_ts directory

Поиск
Список
Период
Сортировка

RE: Patch for migration of the pg_commit_ts directory

От
"Hayato Kuroda (Fujitsu)"
Дата:
Hi,

Thanks for updating the patch. Mostly looks good.

I ran pgindent locally and indents of my part were incorrect. PSA the
included version. 

I have no comments anymore. Thanks for the great work.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


Вложения

Re: Patch for migration of the pg_commit_ts directory

От
Maxim Orlov
Дата:

On Wed, 15 Oct 2025 at 04:46, Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote:
Hi,

Thanks for updating the patch. Mostly looks good.

Yep, looks good to me too.

If there are no objections, I will move forward to mark the thread as
ready for committers.

Hayato Kuroda, you did a great job reviewing this patch; consider to
tag yourself as a reviewer [0].

[0] https://commitfest.postgresql.org/patch/6119/
  
--
Best regards,
Maxim Orlov.

RE: Patch for migration of the pg_commit_ts directory

От
"Hayato Kuroda (Fujitsu)"
Дата:
Dear Hackers,

I found that v7 needs rebased. Copyright was also updated in the attached patch.
I'm not the author of the patch though.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


Вложения

RE: Patch for migration of the pg_commit_ts directory

От
"Hayato Kuroda (Fujitsu)"
Дата:
Hi,

> I didn't quite understand what I needed to do. 
> My assumptions:
> 1. You need to download the postgresql master branch and create a patch file on it.

This is correct. I periodically checked the commitfest app [1], and it has
reported [Needs rebase!] for weeks. Now it could be applied cleanly and tests
could be passed.

> 2. Replace the 2025 with 2026 header comment in all сhangeable patch files.

Since I cannot follow the sentence, let me clarify my understanding.

Basically, the copyright notation is maintained by the PostgreSQL community;
nothing for us to do. They are updated at the beginning of the year [2].
If you are proposing to add new files, however, they must contain the copyright
and be updated in the new year. It's not yet included in the codebase and is out
of scope for the community's maintenance.

Please ask me anything if you have more questions :-).

[1]: https://commitfest.postgresql.org/patch/6119/ 
[2]: https://github.com/postgres/postgres/commit/451c43974f8e199097d97624a4952ad0973cea61

Best regards,
Hayato Kuroda
FUJITSU LIMITED