Обсуждение: BUG #19080: CancelRequest message documentation bug

Поиск
Список
Период
Сортировка

BUG #19080: CancelRequest message documentation bug

От
PG Bug reporting form
Дата:
The following bug has been logged on the website:

Bug reference:      19080
Logged by:          Artem Bezborodko
Email address:      doomedseer@gmail.com
PostgreSQL version: 18.0
Operating system:   N/A
Description:

Starting from 18 version field "Length of message contents in bytes,
including self." should not have predefined value, due to variable key
length. Now it set as (16).


Re: BUG #19080: CancelRequest message documentation bug

От
John Naylor
Дата:
On Thu, Oct 9, 2025 at 9:21 PM PG Bug reporting form
<noreply@postgresql.org> wrote:
> Starting from 18 version field "Length of message contents in bytes,
> including self." should not have predefined value, due to variable key
> length. Now it set as (16).

Seems like an oversight, since the docs describe the v3.2 protocol.
I've attached a fix and CC'd the committer to confirm.

--
John Naylor
Amazon Web Services

Вложения

Re: BUG #19080: CancelRequest message documentation bug

От
John Naylor
Дата:
On Thu, Oct 9, 2025 at 9:21 PM PG Bug reporting form
<noreply@postgresql.org> wrote:
> Starting from 18 version field "Length of message contents in bytes,
> including self." should not have predefined value, due to variable key
> length. Now it set as (16).

This was reported last week on the pgsql-docs list, and has been fixed:

https://www.postgresql.org/message-id/CAAfz9KML7JCZWZsOc2AWgoUHgmRGoOAOR6L%3DxDFe9F3_L1uXAQ%40mail.gmail.com

--
John Naylor
Amazon Web Services



Re: BUG #19080: CancelRequest message documentation bug

От
Heikki Linnakangas
Дата:
On 10 October 2025 05:16:32 CEST, John Naylor <johncnaylorls@gmail.com>
wrote:
>On Thu, Oct 9, 2025 at 9:21 PM PG Bug reporting form
><noreply@postgresql.org> wrote:
>> Starting from 18 version field "Length of message contents in bytes,
>> including self." should not have predefined value, due to variable key
>> length. Now it set as (16).
>
>Seems like an oversight, since the docs describe the v3.2 protocol.
>I've attached a fix and CC'd the committer to confirm.

Yep, thanks! Feel free to commit the fix, or I can do it on Friday myself.

- Heikki



Re: BUG #19080: CancelRequest message documentation bug

От
John Naylor
Дата:
On Tue, Oct 14, 2025 at 6:39 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> Yep, thanks! Feel free to commit the fix, or I can do it on Friday myself.

This has been fixed already, since it was reported on the pgsql-docs
list but I didn't see that until it was committed.

--
John Naylor
Amazon Web Services



Re: BUG #19080: CancelRequest message documentation bug

От
Magnus Hagander
Дата:


On Wed, 15 Oct 2025 at 04:30, John Naylor <johncnaylorls@gmail.com> wrote:
On Tue, Oct 14, 2025 at 6:39 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> Yep, thanks! Feel free to commit the fix, or I can do it on Friday myself.

This has been fixed already, since it was reported on the pgsql-docs
list but I didn't see that until it was committed.

Yeah, and I didn't see the one on -bugs until you pointed it out. Sorry about that!
 
--