Обсуждение: pgsql: Add mem_exceeded_count column to pg_stat_replication_slots.
Add mem_exceeded_count column to pg_stat_replication_slots. This commit introduces a new column mem_exceeded_count to the pg_stat_replication_slots view. This counter tracks how often the memory used by logical decoding exceeds the logical_decoding_work_mem limit. The new statistic helps users determine whether exceeding the logical_decoding_work_mem limit is a rare occurrences or a frequent issue, information that wasn't available through existing statistics. Bumps catversion. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d3b6183dd988928dd369b4b7d641917e77f1ae4e Modified Files -------------- contrib/test_decoding/expected/stats.out | 71 +++++++++++++------------ contrib/test_decoding/sql/stats.sql | 13 +++-- doc/src/sgml/monitoring.sgml | 11 ++++ src/backend/catalog/system_views.sql | 1 + src/backend/replication/logical/logical.c | 8 ++- src/backend/replication/logical/reorderbuffer.c | 34 +++++++++--- src/backend/utils/activity/pgstat_replslot.c | 1 + src/backend/utils/adt/pgstatfuncs.c | 19 ++++--- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.dat | 6 +-- src/include/pgstat.h | 1 + src/include/replication/reorderbuffer.h | 3 ++ src/test/regress/expected/rules.out | 3 +- 13 files changed, 113 insertions(+), 60 deletions(-)
Hi, On Wed, Oct 08, 2025 at 05:05:21PM +0000, Masahiko Sawada wrote: > Add mem_exceeded_count column to pg_stat_replication_slots. > > This commit introduces a new column mem_exceeded_count to the > pg_stat_replication_slots view. This counter tracks how often the > memory used by logical decoding exceeds the logical_decoding_work_mem > limit. The new statistic helps users determine whether exceeding the > logical_decoding_work_mem limit is a rare occurrences or a frequent > issue, information that wasn't available through existing statistics. > > Bumps catversion. > > Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> > Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> > Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> > Reviewed-by: shveta malik <shveta.malik@gmail.com> > Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> > Reviewed-by: Chao Li <li.evan.chao@gmail.com> > Discussion: https://postgr.es/m/978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se I just realized that the discussion mentioned above is not the right one. That should be: https://postgr.es/m/aK6zNcmb%2BPpySFvG%40ip-10-97-1-34.eu-west-3.compute.internal Reporting that here so that the link is not lost. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
On Wed, Oct 29, 2025 at 1:52 AM Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote: > > Hi, > > On Wed, Oct 08, 2025 at 05:05:21PM +0000, Masahiko Sawada wrote: > > Add mem_exceeded_count column to pg_stat_replication_slots. > > > > This commit introduces a new column mem_exceeded_count to the > > pg_stat_replication_slots view. This counter tracks how often the > > memory used by logical decoding exceeds the logical_decoding_work_mem > > limit. The new statistic helps users determine whether exceeding the > > logical_decoding_work_mem limit is a rare occurrences or a frequent > > issue, information that wasn't available through existing statistics. > > > > Bumps catversion. > > > > Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> > > Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> > > Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> > > Reviewed-by: shveta malik <shveta.malik@gmail.com> > > Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> > > Reviewed-by: Chao Li <li.evan.chao@gmail.com> > > Discussion: https://postgr.es/m/978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se > > I just realized that the discussion mentioned above is not the right one. > That should be: https://postgr.es/m/aK6zNcmb%2BPpySFvG%40ip-10-97-1-34.eu-west-3.compute.internal > > Reporting that here so that the link is not lost. > Thank you. That's my fault. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com