Обсуждение: CancelRequest(F) documentation.

Поиск
Список
Период
Сортировка

CancelRequest(F) documentation.

От
Dmitry Igrishin
Дата:
Hello,

CancelRequest(F) documentation at
https://www.postgresql.org/docs/18/protocol-message-formats.html#PROTOCOL-MESSAGE-FORMATS-CANCELREQUEST
seems to be inconsistent for protocol 3.2. It is stated here that the
length of the message is always 16 bytes (specified as Int32(16)),
however the maximum message length actually depends on the secret key
length (which can be up to 256 bytes, as also stated in the
documentation.)

I would propose to specify the overall message length as Int32 in the
documentation for PostgreSQL 18+.

Thanks.



Re: CancelRequest(F) documentation.

От
"Jelte Fennema-Nio"
Дата:
On Tue Oct 7, 2025 at 6:08 PM CEST, Dmitry Igrishin wrote:
> CancelRequest(F) documentation at
> https://www.postgresql.org/docs/18/protocol-message-formats.html#PROTOCOL-MESSAGE-FORMATS-CANCELREQUEST
> seems to be inconsistent for protocol 3.2. It is stated here that the
> length of the message is always 16 bytes (specified as Int32(16)),
> however the maximum message length actually depends on the secret key
> length (which can be up to 256 bytes, as also stated in the
> documentation.)

Good catch. Attached is a patch that fixes this.

Вложения

Re: CancelRequest(F) documentation.

От
Magnus Hagander
Дата:


On Mon, 13 Oct 2025 at 11:57, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
On Tue Oct 7, 2025 at 6:08 PM CEST, Dmitry Igrishin wrote:
> CancelRequest(F) documentation at
> https://www.postgresql.org/docs/18/protocol-message-formats.html#PROTOCOL-MESSAGE-FORMATS-CANCELREQUEST
> seems to be inconsistent for protocol 3.2. It is stated here that the
> length of the message is always 16 bytes (specified as Int32(16)),
> however the maximum message length actually depends on the secret key
> length (which can be up to 256 bytes, as also stated in the
> documentation.)

Good catch. Attached is a patch that fixes this.

Thanks, pushed!

--