Обсуждение: tab_complete for copy(merge

hi.

in v17, we support COPY(MERGE RETURNING)
we can add tab_complete for it.

    /* Complete COPY ( with legal query commands */
    else if (Matches("COPY|\\copy", "("))
-               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH");
+               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH", "MERGE INTO");

On Tue, Nov 19, 2024 at 5:20 PM Kirill Reshke <reshkekirill@gmail.com> wrote:
>
>
> Hi!
>
> On Tue, 19 Nov 2024, 14:08 jian he, <jian.universality@gmail.com> wrote:
>>
>> hi.
>>
>> in v17, we support COPY(MERGE RETURNING)
>> we can add tab_complete for it.
>
>
> Sounds sane
>>
>>     /* Complete COPY ( with legal query commands */
>>     else if (Matches("COPY|\\copy", "("))
>> -               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
>> INTO", "UPDATE", "DELETE FROM", "WITH");
>> +               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
>> INTO", "UPDATE", "DELETE FROM", "WITH", "MERGE INTO");
>
> MERGE INTO?
>

per Synopsis
https://www.postgresql.org/docs/current/sql-merge.html
it should be "MERGE INTO".

On 19.11.24 14:23, jian he wrote:
> On Tue, Nov 19, 2024 at 5:20 PM Kirill Reshke <reshkekirill@gmail.com> wrote:
>> On Tue, 19 Nov 2024, 14:08 jian he, <jian.universality@gmail.com> wrote:
>>> in v17, we support COPY(MERGE RETURNING)
>>> we can add tab_complete for it.
>>
>>
>> Sounds sane
>>>
>>>      /* Complete COPY ( with legal query commands */
>>>      else if (Matches("COPY|\\copy", "("))
>>> -               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
>>> INTO", "UPDATE", "DELETE FROM", "WITH");
>>> +               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
>>> INTO", "UPDATE", "DELETE FROM", "WITH", "MERGE INTO");
>>
>> MERGE INTO?
>>
> 
> per Synopsis
> https://www.postgresql.org/docs/current/sql-merge.html
> it should be "MERGE INTO".

Yes, we also complete "MERGE INTO" in other contexts.

Committed like that.