Обсуждение: Remove dependency on VacuumPage(Hit/Miss/Dirty) counters in do_analyze_rel

Поиск
Список
Период
Сортировка

Remove dependency on VacuumPage(Hit/Miss/Dirty) counters in do_analyze_rel

От
Dilip Kumar
Дата:
As part of commit 5cd72cc0c5017a9d4de8b5d465a75946da5abd1d, the
dependency on global counters such as VacuumPage(Hit/Miss/Dirty) was
removed from the vacuum. However, do_analyze_rel() was still using
these counters, necessitating the tracking of global counters
alongside BufferUsage counters.

The attached patch addresses the issue by eliminating the need to
track VacuumPage(Hit/Miss/Dirty) counters in do_analyze_rel(), making
the global counters obsolete. This simplifies the code and improves
consistency.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Вложения

Re: Remove dependency on VacuumPage(Hit/Miss/Dirty) counters in do_analyze_rel

От
Anthonin Bonnefoy
Дата:

On Thu, Jun 6, 2024 at 11:10 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
As part of commit 5cd72cc0c5017a9d4de8b5d465a75946da5abd1d, the
dependency on global counters such as VacuumPage(Hit/Miss/Dirty) was
removed from the vacuum. However, do_analyze_rel() was still using
these counters, necessitating the tracking of global counters
alongside BufferUsage counters.

The attached patch addresses the issue by eliminating the need to
track VacuumPage(Hit/Miss/Dirty) counters in do_analyze_rel(), making
the global counters obsolete. This simplifies the code and improves
consistency.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
On Thu, Jun 6, 2024 at 3:23 PM Anthonin Bonnefoy
<anthonin.bonnefoy@datadoghq.com> wrote:
>
> Hi,
>
> I sent a similar patch for this in
https://www.postgresql.org/message-id/flat/CAO6_Xqr__kTTCLkftqS0qSCm-J7_xbRG3Ge2rWhucxQJMJhcRA@mail.gmail.com

Okay, I see, In that case, we can just discard mine, thanks for notifying me.


--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com