Обсуждение: pgBackRest 2.52 - New upstream version

Hi All,

I've pushed a commit [1] updating the package version pgbackrest to 2.52
to salsa.debian.org. The GitLab CI is green and the package is ready for
review and upload.


--Bradford

[1]: https://salsa.debian.org/postgresql/pgbackrest/-/commit/4bed3fd233fae4bd09487d559b9251786b3260c4

Hi All,

Just following up to see if there are any blockers to having pgbackrest
uploaded.

--Bradford

Re: Bradford Boyle
> Just following up to see if there are any blockers to having pgbackrest
> uploaded.

Hi Bradford,

mostly me hiking in the woods for the last days...

But unfortunately, bullseye and focal are not happy:

../meson.build:117:0: ERROR: <ExternalProgram 'python3' -> ['/usr/bin/python3']> is not a valid python or it is missing
setuptools

(Interestingly, buster is happy with the meson+python3 combination)

Christoph

Hi Christoph,

> But unfortunately, bullseye and focal are not happy:
>
> ../meson.build:117:0: ERROR: <ExternalProgram 'python3' -> ['/usr/bin/python3']> is not a valid python or it is
missingsetuptools
 
>
> (Interestingly, buster is happy with the meson+python3 combination)

I will take a look at this later today and see if I can identify and
push a fix.

Thanks,
--Bradford

On 6/4/24 06:41, Bradford Boyle wrote:
> Hi Christoph,
> 
>> But unfortunately, bullseye and focal are not happy:
>>
>> ../meson.build:117:0: ERROR: <ExternalProgram 'python3' -> ['/usr/bin/python3']> is not a valid python or it is
missingsetuptools
 
>>
>> (Interestingly, buster is happy with the meson+python3 combination)
> 
> I will take a look at this later today and see if I can identify and
> push a fix.

This is actually a bug/typo in older versions of meson. What is actually 
required (in some cases) is python3-distutils. See 
https://github.com/pgbackrest/pgbackrest/commit/e00e33b52. The purpose 
of this commit is to not hardcode the python bin.

However, this requirement is only for certain older (but not too old) 
versions of Debian/Ubuntu. Ubuntu 24.04, for instance, does not have 
this package and works fine without it. Of the Ubuntu versions only 
focal seems to require it. The only Debian version we currently have in 
CI, stretch, does not require it.

It's a bit of a mess, but looks like we need to install 
python3-distutils just for bullseye and focal as a build dependency. Is 
that possible?

Regards,
-David

Hi David and Christoph,

> This is actually a bug/typo in older versions of meson. What is actually
> required (in some cases) is python3-distutils.

I found [this issue][1] on GitHub repo for meson which indicates that
meson 0.48.0 added a dependency on python's setuptools module. This
issue is quite old but it was referenced by a [newer pull request][2]
that seems to indicate that at some point meson depended on python's
distutils module. This PR was referenced by an even [newer PR][3] that
seems to indicate that meson moved away from using the distutils module.
This is probably why this is only an issue in bullseye or focal and not
older or newer dists.

> It's a bit of a mess, but looks like we need to install
> python3-distutils just for bullseye and focal as a build dependency. Is
> that possible?

Adding python3-distutils for just bullseye and focal should be doable. I
believe the scripts used to build the packages for the PGDG apt repo has
an existing pattern for tweaking the package. Attached is a patch that
should add python3-distutils to pgbackrest's list of build dependencies
only on bullseye or focal.

--Bradford


[1]: https://github.com/mesonbuild/meson/issues/4267
[2]: https://github.com/mesonbuild/meson/pull/9288
[3]: https://github.com/mesonbuild/meson/pull/11133

Re: Bradford Boyle
> > It's a bit of a mess, but looks like we need to install
> > python3-distutils just for bullseye and focal as a build dependency. Is
> > that possible?

We should keep it simple and add it unconditionally. python3-distutils
is needed on python < 3.10, so I used this:

    python3 (>= 3.10) | python3-distutils

Christoph

On 6/4/24 19:43, Christoph Berg wrote:
> Re: Bradford Boyle
>>> It's a bit of a mess, but looks like we need to install
>>> python3-distutils just for bullseye and focal as a build dependency. Is
>>> that possible?
> 
> We should keep it simple and add it unconditionally. python3-distutils
> is needed on python < 3.10, so I used this:
> 
>      python3 (>= 3.10) | python3-distutils
> 

This seems reasonable, though I do wish there was a meson-specific way 
to fix this. I guess their answer would be to upgrade.

Regards,
-David