Обсуждение: Fix badly generated entries in wait_event_names.txt

Поиск
Список
Период
Сортировка

Fix badly generated entries in wait_event_names.txt

От
"Drouvot, Bertrand"
Дата:
Hi hackers,

fa88928470 introduced src/backend/utils/activity/wait_event_names.txt that has
been auto-generated. The auto-generation had parsing errors leading to bad
entries in wait_event_names.txt (when the same "WAIT_EVENT" name can be found as
a substring of another one, then descriptions were merged in one of them).

Fixing those bad entries in the attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Вложения

Re: Fix badly generated entries in wait_event_names.txt

От
Michael Paquier
Дата:
On Mon, Aug 07, 2023 at 10:34:43AM +0200, Drouvot, Bertrand wrote:
> fa88928470 introduced src/backend/utils/activity/wait_event_names.txt that has
> been auto-generated. The auto-generation had parsing errors leading to bad
> entries in wait_event_names.txt (when the same "WAIT_EVENT" name can be found as
> a substring of another one, then descriptions were merged in one of them).

Thanks for the patch, applied.  I have double-checked the contents of
the tables and the five entries you have pointed out are the only ones
with duplicated descriptions.
--
Michael

Вложения

Re: Fix badly generated entries in wait_event_names.txt

От
"Drouvot, Bertrand"
Дата:
Hi,

On 8/8/23 1:25 AM, Michael Paquier wrote:
> On Mon, Aug 07, 2023 at 10:34:43AM +0200, Drouvot, Bertrand wrote:
>> fa88928470 introduced src/backend/utils/activity/wait_event_names.txt that has
>> been auto-generated. The auto-generation had parsing errors leading to bad
>> entries in wait_event_names.txt (when the same "WAIT_EVENT" name can be found as
>> a substring of another one, then descriptions were merged in one of them).
> 
> Thanks for the patch, applied. 

Thanks!

> I have double-checked the contents of
> the tables and the five entries you have pointed out are the only ones
> with duplicated descriptions.

Yeah, did the same on my side before submitting the patch, and all looks
good now.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com