Обсуждение: RelationGetIndexAttrBitmap comment outdated

Поиск
Список
Период
Сортировка

RelationGetIndexAttrBitmap comment outdated

От
Alvaro Herrera
Дата:
I realized that commit 19d8e2308bc5 (and 5753d4ee320b before that) added
a new output type to RelationGetIndexAttrBitmap but forgot to list its
effect in the function's documenting comment.  Here's a patch that
updates it, making it more specific (and IMO more readable).  I also add
a comment to the enum definition, to remind people that the other one
needs to be modified.

This ought to be backpatched to 16.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"La conclusión que podemos sacar de esos estudios es que
no podemos sacar ninguna conclusión de ellos" (Tanenbaum)

Вложения

Re: RelationGetIndexAttrBitmap comment outdated

От
Daniel Gustafsson
Дата:
> On 12 Jul 2023, at 16:37, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> 
> I realized that commit 19d8e2308bc5 (and 5753d4ee320b before that) added
> a new output type to RelationGetIndexAttrBitmap but forgot to list its
> effect in the function's documenting comment.  Here's a patch that
> updates it, making it more specific (and IMO more readable).  I also add
> a comment to the enum definition, to remind people that the other one
> needs to be modified.

LGTM, a clear improvement.

> This ought to be backpatched to 16.

+1

--
Daniel Gustafsson