Обсуждение: Wrong syntax in feature description

Hi, I noticed a feature description [1] referring to a command example:

CREATE PUBLICATION ... FOR ALL TABLES IN SCHEMA ....

~~

AFAIK that should say "FOR TABLES IN SCHEMA" (without the "ALL", see [2])

------
[1] https://www.postgresql.org/about/featurematrix/detail/391/
[2] https://www.postgresql.org/docs/16/sql-createpublication.html

Kind Regards,
Peter Smith.
Fujitsu Australia

On Fri, Jun 2, 2023 at 7:01 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi, I noticed a feature description [1] referring to a command example:
>
> CREATE PUBLICATION ... FOR ALL TABLES IN SCHEMA ....
>
> ~~
>
> AFAIK that should say "FOR TABLES IN SCHEMA" (without the "ALL", see [2])
>

Right, this should be changed.

--
With Regards,
Amit Kapila.

> On 4 Jun 2023, at 18:48, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Jun 2, 2023 at 7:01 PM Peter Smith <smithpb2250@gmail.com> wrote:
>>
>> Hi, I noticed a feature description [1] referring to a command example:
>>
>> CREATE PUBLICATION ... FOR ALL TABLES IN SCHEMA ....
>>
>> ~~
>>
>> AFAIK that should say "FOR TABLES IN SCHEMA" (without the "ALL", see [2])
>
> Right, this should be changed.

Agreed, so I've fixed this in the featurematrix on the site.  I will mark this
CF entry as committed even though there is nothing to commit (the featurematrix
is stored in the postgresql.org django instance) since there was a change
performed.

Thanks for the report!

--
Daniel Gustafsson

On Wed, Jul 5, 2023 at 5:37 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 4 Jun 2023, at 18:48, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Fri, Jun 2, 2023 at 7:01 PM Peter Smith <smithpb2250@gmail.com> wrote:
> >>
> >> Hi, I noticed a feature description [1] referring to a command example:
> >>
> >> CREATE PUBLICATION ... FOR ALL TABLES IN SCHEMA ....
> >>
> >> ~~
> >>
> >> AFAIK that should say "FOR TABLES IN SCHEMA" (without the "ALL", see [2])
> >
> > Right, this should be changed.
>
> Agreed, so I've fixed this in the featurematrix on the site.  I will mark this
> CF entry as committed even though there is nothing to commit (the featurematrix
> is stored in the postgresql.org django instance) since there was a change
> performed.
>
> Thanks for the report!

Thanks for (not) pushing ;-)

------
Kind Regards,
Peter Smith.
Fujitsu Australia