Обсуждение: errdetail/errhint style

Поиск
Список
Период
Сортировка

errdetail/errhint style

От
Justin Pryzby
Дата:
Most of these are new in v15.
In any case, I'm not sure if the others ought to be backpatched.
There may be additional fixes to make with the same grepping.

Вложения

Re: errdetail/errhint style

От
Alvaro Herrera
Дата:
On 2022-Jul-19, Justin Pryzby wrote:

> https://www.postgresql.org/docs/current/error-style-guide.html#id-1.10.6.4.7
> 
> git grep 'errdetail("[[:lower:]]'
> git grep 'errdetail(".*".*;' |grep -v '\."'

Hmm, +1, though a few of these are still missing ending periods after
your patch.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"The problem with the facetime model is not just that it's demoralizing, but
that the people pretending to work interrupt the ones actually working."
                                                           (Paul Graham)



Re: errdetail/errhint style

От
Michael Paquier
Дата:
On Tue, Jul 19, 2022 at 02:31:28PM +0200, Alvaro Herrera wrote:
> Hmm, +1, though a few of these are still missing ending periods after
> your patch.

+1.
--
Michael

Вложения

Re: errdetail/errhint style

От
Michael Paquier
Дата:
On Tue, Jul 19, 2022 at 09:51:13PM +0900, Michael Paquier wrote:
> +1.

I have looked at that and added the extra periods, and applied it.
Thanks, Justin.
--
Michael

Вложения