Обсуждение: Fix a possible typo in rewriteheap.c code comments

Поиск
Список
Период
Сортировка

Fix a possible typo in rewriteheap.c code comments

От
Bharath Rupireddy
Дата:
Hi,

It looks like there's a typo, attaching a tiny patch to fix it.

  *
  * When doing logical decoding - which relies on using cmin/cmax of catalog
  * tuples, via xl_heap_new_cid records - heap rewrites have to log enough
- * information to allow the decoding backend to updates its internal mapping
+ * information to allow the decoding backend to update its internal mapping

Regards,
Bharath Rupireddy.

Вложения

Re: Fix a possible typo in rewriteheap.c code comments

От
Amit Kapila
Дата:
On Mon, Jan 10, 2022 at 9:42 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> Hi,
>
> It looks like there's a typo, attaching a tiny patch to fix it.
>
>   *
>   * When doing logical decoding - which relies on using cmin/cmax of catalog
>   * tuples, via xl_heap_new_cid records - heap rewrites have to log enough
> - * information to allow the decoding backend to updates its internal mapping
> + * information to allow the decoding backend to update its internal mapping
>

LGTM.

-- 
With Regards,
Amit Kapila.



Re: Fix a possible typo in rewriteheap.c code comments

От
Amit Kapila
Дата:
On Mon, Jan 10, 2022 at 10:22 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Jan 10, 2022 at 9:42 AM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
> >
> > Hi,
> >
> > It looks like there's a typo, attaching a tiny patch to fix it.
> >
> >   *
> >   * When doing logical decoding - which relies on using cmin/cmax of catalog
> >   * tuples, via xl_heap_new_cid records - heap rewrites have to log enough
> > - * information to allow the decoding backend to updates its internal mapping
> > + * information to allow the decoding backend to update its internal mapping
> >
>
> LGTM.
>

Pushed.

-- 
With Regards,
Amit Kapila.