Обсуждение: Re: pgsql: Refactor tar method of walmethods.c to rely on the compression m

Re: Michael Paquier
> Refactor tar method of walmethods.c to rely on the compression method

Hi,

since about this commit, pg_wal.tar is no longer compressed at all:

$ pg_basebackup -D foo --format=tar
$ ls -l foo/
-rw-------  1 cbe cbe   137152  7. Jan 15:37 backup_manifest
-rw-------  1 cbe cbe 23606272  7. Jan 15:37 base.tar
-rw-------  1 cbe cbe 16778752  7. Jan 15:37 pg_wal.tar

$ pg_basebackup -D foogz --format=tar --gzip
$ ls -l foogz
-rw-------  1 cbe cbe   137152  7. Jan 15:37 backup_manifest
-rw-------  1 cbe cbe  3073257  7. Jan 15:37 base.tar.gz
-rw-------  1 cbe cbe 16779264  7. Jan 15:37 pg_wal.tar     <-- should be pg_wal.tar.gz

Christoph

On Fri, Jan 07, 2022 at 03:41:16PM +0100, Christoph Berg wrote:
> since about this commit, pg_wal.tar is no longer compressed at all:

Thanks.  That's a thinko coming from the fact that
Z_DEFAULT_COMPRESSION is -1, combination possible when specifying only
--gzip.  So, fixed.
--
Michael