Обсуждение: [PATCHES] pglister: make organization name generic

Hello,

PGLister is currently made to be run for PostgreSQL only. In an effort to get this software used by other
organizations,this series of patches defines an ORGANIZATION_NAME configuration option and uses it to replace mentions
ofPostreSQL in templates.
 
Additionally, new images for the banner are proposed, to replace mentions of PostreSQL by a sober "PGLister". Postgres'
logois, however, kept.
 

Cheers,
-- 
Célestin Matte

-- 
Célestin Matte

-- 
Célestin Matte

-- 
Célestin Matte

Third patch seems to fail to be pass the list's spam filter, so please find it here:
https://ploudseeker.com/files/0003-Update-banner-images-to-remove-mentions-of-PostreSQL.patch

-- 
Célestin Matte

On 11/2/21 12:26 PM, Célestin Matte wrote:
> Third patch seems to fail to be pass the list's spam filter

These go into a moderation queue. I went ahead and approved it.

Thanks,

Jonathan

On 2021-Nov-02, Célestin Matte wrote:

> @@ -14,8 +14,8 @@
>      <div class="container">
>        <div class="row">
>      <div class="col-sm-12" id="pglisterhdr">
> -      <a href="/"><img src="/media/img/hdr_left.png" alt="PostgreSQL" /></a>
> -      <img class="pull-right hidden-xs" src="/media/img/hdr_right.png" alt="The world's most advanced open source
database"/>
 
> +      <a href="/"><img src="/media/img/hdr_left.png" alt="{% orgname %}" /></a>
> +      <img class="pull-right hidden-xs" src="/media/img/hdr_right.png" />

{% motto %} -> The world's most advanced open source database ;-)


-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/
"I dream about dreams about dreams", sang the nightingale
under the pale moon (Sandman)

> As a general rule, please post the patches no the thread of the description, and if it's more than one patch, in the
sameemail. Right now the only thing I see to review is this description, that's kind of hard.
 

Sorry, I don't understand: should I send all patches by responding to the description email (instead of replying to the
previousones, as I did here), or all patches in the same email?
 

> As for reviewing the general idea, I agree with that -- makes perfect sense to do that. I did note that Alvaro
spottedthat it also needs to look over all the rest of the text and find similar stuff -- like the image alt=""
attribute.There may be more of those?
 

Yep, added handling of ORGANIZATION_MOTTO in the set of patches attached to this email.

-- 
Célestin Matte

On Thu, Nov 4, 2021 at 12:21 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
>
> > As a general rule, please post the patches no the thread of the description, and if it's more than one patch, in
thesame email. Right now the only thing I see to review is this description, that's kind of hard. 
>
> Sorry, I don't understand: should I send all patches by responding to the description email (instead of replying to
theprevious ones, as I did here), or all patches in the same email? 

All in the same email is definitely best, like you did in this one -- thanks!

> > As for reviewing the general idea, I agree with that -- makes perfect sense to do that. I did note that Alvaro
spottedthat it also needs to look over all the rest of the text and find similar stuff -- like the image alt=""
attribute.There may be more of those? 
>
> Yep, added handling of ORGANIZATION_MOTTO in the set of patches attached to this email.

Looking at 1 and 2, this just seems to me like a strange way to do it,
by declaring a new tag for it.

I think it would be cleaner with a Context Processor similar to what
we have in pgweb. Then this context processor could just return a dict
of ORGANIZATION_INFO from setitngs.py, wihch would have a key for name
and a key for motto perhaps?

As for 3 -- I don't think we want to remove the postgresql branding It
should be made optional though, perhaps by another parameter in said
dict in the settings that would just make it load from different URLs
and files?

--
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/

> I think it would be cleaner with a Context Processor similar to what
> we have in pgweb. Then this context processor could just return a dict
> of ORGANIZATION_INFO from setitngs.py, wihch would have a key for name
> and a key for motto perhaps?
> 
> As for 3 -- I don't think we want to remove the postgresql branding It
> should be made optional though, perhaps by another parameter in said
> dict in the settings that would just make it load from different URLs
> and files?

All done in attached series of patches!

-- 
Célestin Matte

Hi there. Would it be easier if I sent pglister-related patches in MR on gitlab instead of the list?

> 
> All done in attached series of patches!
> 

-- 
Célestin Matte

On Tue, Jan 25, 2022 at 10:36 AM Célestin Matte
<celestin.matte@cmatte.me> wrote:
>
> Hi there. Would it be easier if I sent pglister-related patches in MR on gitlab instead of the list?

Doesn't really matter from our perspective I think. We're just
generally backlogged and slow to review them regardless of where
they're submitted - sorry about that. I think if anything this list
might get marginally higher visibility and at least in theory attract
an extra reviewer. In practice, I don't think it makes a difference.

--
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/

Adding to this series of patches the possibility to configure links in the banner

On 19/01/2022 10:48, Célestin Matte wrote:
>> I think it would be cleaner with a Context Processor similar to what
>> we have in pgweb. Then this context processor could just return a dict
>> of ORGANIZATION_INFO from setitngs.py, wihch would have a key for name
>> and a key for motto perhaps?
>>
>> As for 3 -- I don't think we want to remove the postgresql branding It
>> should be made optional though, perhaps by another parameter in said
>> dict in the settings that would just make it load from different URLs
>> and files?
> 
> All done in attached series of patches!
> 

-- 
Célestin Matte