Обсуждение: Typo in DATATYPE-JSONPATH

Поиск
Список
Период
Сортировка

Typo in DATATYPE-JSONPATH

От
PG Doc comments form
Дата:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/datatype-json.html
Description:

Hello,

On the DATATYPE-JSONPATH page:
https://www.postgresql.org/docs/13/datatype-json.html#DATATYPE-JSONPATH

There is a line that shows that GIN indexes support `@@` and `@?` operators
for json matching, then there are two examples trying to show both
operators. However both examples use the `@@` operator.

Examples from the doc:

SELECT jdoc->'guid', jdoc->'name' FROM api WHERE jdoc @@ '$.tags[*] ==
"qui"';
SELECT jdoc->'guid', jdoc->'name' FROM api WHERE jdoc @@ '$.tags[*] ? (@ ==
"qui")';

I think the second example should be using the `@?` operator so that both
sample queries do the same thing but with the different operator types. So
the second example should read:

SELECT jdoc->'guid', jdoc->'name' FROM api WHERE jdoc @? '$.tags[*] ? (@ ==
"qui")';

Thank you,
Ben

Re: Typo in DATATYPE-JSONPATH

От
Erik Rijkers
Дата:
> On 2021.04.15. 22:04 PG Doc comments form <noreply@postgresql.org> wrote:
>  
> Page: https://www.postgresql.org/docs/13/datatype-json.html
> Description:
> 
> Hello,
> 
> On the DATATYPE-JSONPATH page:
> https://www.postgresql.org/docs/13/datatype-json.html#DATATYPE-JSONPATH
> 
> There is a line that shows that GIN indexes support `@@` and `@?` operators
> for json matching, then there are two examples trying to show both
> operators. However both examples use the `@@` operator.
> 
> Examples from the doc:
> 
> SELECT jdoc->'guid', jdoc->'name' FROM api WHERE jdoc @@ '$.tags[*] ==
> "qui"';
> SELECT jdoc->'guid', jdoc->'name' FROM api WHERE jdoc @@ '$.tags[*] ? (@ ==
> "qui")';
> 
> I think the second example should be using the `@?` operator so that both
> sample queries do the same thing but with the different operator types. So
> the second example should read:
> 
> SELECT jdoc->'guid', jdoc->'name' FROM api WHERE jdoc @? '$.tags[*] ? (@ ==
> "qui")';
>
> Thank you,
> Ben

FWIW, I agree with this and already sent a doc-patch [1], which is be applied from 12, 13, and master. 

Erik


[1] https://www.postgresql.org/message-id/1219476687.20432.1617452918468@webmailclassic.xs4all.nl



Re: Typo in DATATYPE-JSONPATH

От
Michael Paquier
Дата:
On Fri, Apr 16, 2021 at 08:11:53AM +0200, Erik Rijkers wrote:
> FWIW, I agree with this and already sent a doc-patch [1], which is
> be applied from 12, 13, and master.

Arf.  I completely forgot about this thread but I marked it as
something to look at.  Will do so now.
--
Michael

Вложения