Обсуждение: pgsql: pg_alterckey: remove TAP check rules from Makefile
pg_alterckey: remove TAP check rules from Makefile Reported-by: Pavel Stehule, Michael Paquier Discussion: https://postgr.es/m/CAFj8pRBRNo4co5bqCx4BLx1ZZ45Z_T-opPxA+u7SLp7gAtBpNA@mail.gmail.com Backpatch-through: master Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e174a6f1937248886e124cdb68408e727aeea278 Modified Files -------------- src/bin/pg_alterckey/Makefile | 6 ------ 1 file changed, 6 deletions(-)
so 26. 12. 2020 v 15:03 odesílatel Bruce Momjian <bruce@momjian.us> napsal:
pg_alterckey: remove TAP check rules from Makefile
Reported-by: Pavel Stehule, Michael Paquier
Discussion: https://postgr.es/m/CAFj8pRBRNo4co5bqCx4BLx1ZZ45Z_T-opPxA+u7SLp7gAtBpNA@mail.gmail.com
Backpatch-through: master
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e174a6f1937248886e124cdb68408e727aeea278
Modified Files
--------------
src/bin/pg_alterckey/Makefile | 6 ------
1 file changed, 6 deletions(-)
it is fixed
Thank you
Pavel
On Sat, Dec 26, 2020 at 04:23:59PM +0100, Pavel Stehule wrote: > Details > ------- > https://git.postgresql.org/pg/commitdiff/ > e174a6f1937248886e124cdb68408e727aeea278 > > Modified Files > -------------- > src/bin/pg_alterckey/Makefile | 6 ------ > 1 file changed, 6 deletions(-) > > > it is fixed Thank you for your report. When I did the Windows port and pg_upgrade, we didn't have all of the test infrastructure we have now, so I wasn't even aware of all of this. The buildfarm is almost all green now so I think we are out of the woods on this. Eventually we are going to need TAP tests for this, but right now there isn't really anything user-visible to test. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee
aOn Sat, Dec 26, 2020 at 10:27:24AM -0500, Bruce Momjian wrote: > Thank you for your report. When I did the Windows port and pg_upgrade, > we didn't have all of the test infrastructure we have now, so I wasn't > even aware of all of this. The buildfarm is almost all green now so I > think we are out of the woods on this. Eventually we are going to need > TAP tests for this, but right now there isn't really anything > user-visible to test. Oh, even once we have TAP tests, things like testing against AWS Security Manager or a Yubikey would be pretty hard to automate in our tree. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee
so 26. 12. 2020 v 16:27 odesílatel Bruce Momjian <bruce@momjian.us> napsal:
On Sat, Dec 26, 2020 at 04:23:59PM +0100, Pavel Stehule wrote:
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/
> e174a6f1937248886e124cdb68408e727aeea278
>
> Modified Files
> --------------
> src/bin/pg_alterckey/Makefile | 6 ------
> 1 file changed, 6 deletions(-)
>
>
> it is fixed
Thank you for your report. When I did the Windows port and pg_upgrade,
we didn't have all of the test infrastructure we have now, so I wasn't
even aware of all of this. The buildfarm is almost all green now so I
think we are out of the woods on this. Eventually we are going to need
TAP tests for this, but right now there isn't really anything
user-visible to test.
There is enough time to end the current release cycle.
Regards
Pavel
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
so 26. 12. 2020 v 16:33 odesílatel Bruce Momjian <bruce@momjian.us> napsal:
aOn Sat, Dec 26, 2020 at 10:27:24AM -0500, Bruce Momjian wrote:
> Thank you for your report. When I did the Windows port and pg_upgrade,
> we didn't have all of the test infrastructure we have now, so I wasn't
> even aware of all of this. The buildfarm is almost all green now so I
> think we are out of the woods on this. Eventually we are going to need
> TAP tests for this, but right now there isn't really anything
> user-visible to test.
Oh, even once we have TAP tests, things like testing against AWS
Security Manager or a Yubikey would be pretty hard to automate in our
tree.
The tests against real services should not work (not for community release). There should be some fake API.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee