Обсуждение: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e
revert removal of hex_decode() from ecpg from commit c3826f831e ecpglib on certain platforms can't handle the pg_log_fatal calls from libraries. This was reported by the buildfarm. It needs a refactoring and return value change if it is later removed. Backpatch-through: master Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/558a6e8e21367dae9a294291337be10a8a4afd0a Modified Files -------------- src/interfaces/ecpg/ecpglib/data.c | 52 +++++++++++++++++++++++++++++++++++++- 1 file changed, 51 insertions(+), 1 deletion(-)
Bruce Momjian <bruce@momjian.us> writes:
> revert removal of hex_decode() from ecpg from commit c3826f831e
> ecpglib on certain platforms can't handle the pg_log_fatal calls from
> libraries. This was reported by the buildfarm. It needs a refactoring
> and return value change if it is later removed.
Just for the record: even without the link failures, this was a pretty
awful idea. ecpglib has no business calling pg_log_fatal(), much less
exit().
regards, tom lane
On Thu, Dec 24, 2020 at 06:25:56PM -0500, Tom Lane wrote: > Bruce Momjian <bruce@momjian.us> writes: > > revert removal of hex_decode() from ecpg from commit c3826f831e > > ecpglib on certain platforms can't handle the pg_log_fatal calls from > > libraries. This was reported by the buildfarm. It needs a refactoring > > and return value change if it is later removed. > > Just for the record: even without the link failures, this was a pretty > awful idea. ecpglib has no business calling pg_log_fatal(), much less > exit(). I should have realized it was the _lib_ calling it, and not ecpg itself. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee