Обсуждение: pgsql: Change the attribute name in pg_stat_replication_slots view.
Change the attribute name in pg_stat_replication_slots view. Change the attribute 'name' to 'slot_name' in pg_stat_replication_slots view to make it clear and that way we will be consistent with the other places like pg_stat_wal_receiver view where we display the same attribute. In the passing, fix the typo in one of the macros in the related code. Bump the catversion as we have modified the name in the catalog as well. Reported-by: Noriyoshi Shinoda Author: Noriyoshi Shinoda Reviewed-by: Sawada Masahiko and Amit Kapila Discussion: https://postgr.es/m/CA+fd4k5_pPAYRTDrO2PbtTOe0eHQpBvuqmCr8ic39uTNmR49Eg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/03d51b776d88badbeb4452c1ab452feb78dce36a Modified Files -------------- contrib/test_decoding/expected/stats.out | 14 +++++++------- contrib/test_decoding/sql/stats.sql | 8 ++++---- doc/src/sgml/monitoring.sgml | 2 +- src/backend/catalog/system_views.sql | 2 +- src/backend/utils/adt/pgstatfuncs.c | 6 +++--- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.dat | 2 +- src/test/regress/expected/rules.out | 4 ++-- 8 files changed, 20 insertions(+), 20 deletions(-)
Hi, On 2020-10-20 04:56:00 +0000, Amit Kapila wrote: > Change the attribute name in pg_stat_replication_slots view. > > Change the attribute 'name' to 'slot_name' in pg_stat_replication_slots > view to make it clear and that way we will be consistent with the other > places like pg_stat_wal_receiver view where we display the same attribute. > > In the passing, fix the typo in one of the macros in the related code. > > Bump the catversion as we have modified the name in the catalog as well. This is missing a catversion bump... Greetings, Andres Freund
Hi,
On 2020-12-07 10:49:11 -0800, Andres Freund wrote:
> On 2020-10-20 04:56:00 +0000, Amit Kapila wrote:
> > Change the attribute name in pg_stat_replication_slots view.
> >
> > Change the attribute 'name' to 'slot_name' in pg_stat_replication_slots
> > view to make it clear and that way we will be consistent with the other
> > places like pg_stat_wal_receiver view where we display the same attribute.
> >
> > In the passing, fix the typo in one of the macros in the related code.
> >
> > Bump the catversion as we have modified the name in the catalog as well.
>
> This is missing a catversion bump...
Err, sorry, this is the wrong thread. Was trying to respond to:
commit 01469241b2ff6f17fc0b3f20f01559145ffab29e
Author: Fujii Masao <fujii@postgresql.org>
Date: 2020-12-02 13:00:15 +0900
Track total number of WAL records, FPIs and bytes generated in the cluster.
Not sure what happened.
Greetings,
Andres Freund