Обсуждение: Magic number for SSLRequest

Поиск
Список
Период
Сортировка

Magic number for SSLRequest

От
PG Doc comments form
Дата:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/11/protocol-message-formats.html
Description:

On page: https://www.postgresql.org/docs/11/protocol-message-formats.html

it says for SSLRequest packet:

Int32(80877103)
The SSL request code. The value is chosen to contain 1234 in the most
significant 16 bits, and 5679 in the least significant 16 bits.

I don't see how that works. 0x12345678 is 305,419,897.

80877103 decimal in hex is 0x04D2162F

I looked at the packet using Wireshark and it is indeed 0x4D2162F, so the
documentation is correct, except for the explanation about why this number.
It looks like an arbitrary number to me. Not that there's anything wrong
with that.

I suggest removing the sentence "The value is chosen to contain 1234 in the
most significant 16 bits, and 5679 in the least significant 16 bits." which
seems incorrect to me.

Thanks!

Re: Magic number for SSLRequest

От
Magnus Hagander
Дата:


On Fri, Sep 18, 2020 at 1:07 PM PG Doc comments form <noreply@postgresql.org> wrote:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/11/protocol-message-formats.html
Description:

On page: https://www.postgresql.org/docs/11/protocol-message-formats.html

it says for SSLRequest packet:

Int32(80877103)
The SSL request code. The value is chosen to contain 1234 in the most
significant 16 bits, and 5679 in the least significant 16 bits.

I don't see how that works. 0x12345678 is 305,419,897.

80877103 decimal in hex is 0x04D2162F

It's 1234 and 5679, not 0x1234 and 0x5679. That is, it's decimal, not hexadecimal.

0x04D2 = 1234
0x162F = 5679

--

Re: Magic number for SSLRequest

От
Max Tardiveau
Дата:
My bad -- thanks for the clarification.

— Max


On Sep 18, 2020, at 4:09 AM, Magnus Hagander <magnus@hagander.net> wrote:




On Fri, Sep 18, 2020 at 1:07 PM PG Doc comments form <noreply@postgresql.org> wrote:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/11/protocol-message-formats.html
Description:

On page: https://www.postgresql.org/docs/11/protocol-message-formats.html

it says for SSLRequest packet:

Int32(80877103)
The SSL request code. The value is chosen to contain 1234 in the most
significant 16 bits, and 5679 in the least significant 16 bits.

I don't see how that works. 0x12345678 is 305,419,897.

80877103 decimal in hex is 0x04D2162F

It's 1234 and 5679, not 0x1234 and 0x5679. That is, it's decimal, not hexadecimal.

0x04D2 = 1234
0x162F = 5679

--