Обсуждение: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder (i.e pgadmin4/web/coverage or PEM/web/coverage).
For reference purpose have attached screenshot with this email & segregated patch for PEM/pgadmin.
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
Вложения
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
To: Postgres Enterprise Manager <pem@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder (i.e pgadmin4/web/coverage or PEM/web/coverage).
For reference purpose have attached screenshot with this email & segregated patch for PEM/pgadmin.
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
Вложения
Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
Вложения
Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--
Вложения
Hi AdityaPlease review it.On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & RegardsAkshay JoshipgAdmin Hacker | Sr. Software ArchitectEDB PostgresMobile: +91 976-788-8246
Вложения
Sure Aditya, appreciates your feedback.
I will be doing a cross check with below requirements & get back with updates.
Thanks !
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Thursday, 6 August 2020 at 6:04 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>
Subject: Re: Code coverage report generation for JS files
Hi Pramod,
The patch looks good to me except:
1) Remove commented code.
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
3) Add the new coverage directory to .gitignore.
On Thu, Aug 6, 2020 at 4:59 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya
Please review it.
On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Вложения
Hi Pramod,The patch looks good to me except:1) Remove commented code.2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.3) Add the new coverage directory to .gitignore.On Thu, Aug 6, 2020 at 4:59 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaPlease review it.On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & RegardsAkshay JoshipgAdmin Hacker | Sr. Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks,Aditya ToshniwalpgAdmin hacker | Sr. Software Engineer | edbpostgres.com"Don't Complain about Heat, Plant a TREE"
Вложения
Yes Dave, this morning itself I experimented this lcov report generation with sonarqube.
Imported it in sonarqube server (local) & it worked very well. In fact it started showing coverage progress for all the JS files in dir.
Also its possible to include multiple lcov files (language specific i.e python/js) for coverage report generation.
From: Dave Page <dpage@pgadmin.org>
Date: Thursday, 6 August 2020 at 6:18 PM
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: Pramod Ahire <pramod.ahire@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>
Subject: Re: Code coverage report generation for JS files
Hmm, this makes me think - if we have enough of the JS infrastructure on the SonarQube scanner server (which is easy to create in the Jenkins job), we could import the lcov reports into SonarQube.
On Thu, Aug 6, 2020 at 1:34 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pramod,
The patch looks good to me except:
1) Remove commented code.
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
3) Add the new coverage directory to .gitignore.
On Thu, Aug 6, 2020 at 4:59 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya
Please review it.
On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
Вложения
Hi Aditya,
As per your feedback, pleas find updates as below:
1) Remove commented code. Done
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
- Updated package.json for : "test:karma-coverage" & "test:karma-coverage-once"
3) Add the new coverage directory to .gitignore. Done
Have attached patch with email.
Thanks you !
From: Dave Page <dpage@pgadmin.org>
Date: Thursday, 6 August 2020 at 6:18 PM
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: Pramod Ahire <pramod.ahire@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>
Subject: Re: Code coverage report generation for JS files
Hmm, this makes me think - if we have enough of the JS infrastructure on the SonarQube scanner server (which is easy to create in the Jenkins job), we could import the lcov reports into SonarQube.
On Thu, Aug 6, 2020 at 1:34 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pramod,
The patch looks good to me except:
1) Remove commented code.
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
3) Add the new coverage directory to .gitignore.
On Thu, Aug 6, 2020 at 4:59 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya
Please review it.
On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
Вложения
Hi Aditya,
As per your feedback, pleas find updates as below:
1) Remove commented code. Done
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
- Updated package.json for : "test:karma-coverage" & "test:karma-coverage-once"
3) Add the new coverage directory to .gitignore. Done
Have attached patch with email.
Thanks you !
From: Dave Page <dpage@pgadmin.org>
Date: Thursday, 6 August 2020 at 6:18 PM
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: Pramod Ahire <pramod.ahire@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>
Subject: Re: Code coverage report generation for JS files
Hmm, this makes me think - if we have enough of the JS infrastructure on the SonarQube scanner server (which is easy to create in the Jenkins job), we could import the lcov reports into SonarQube.
On Thu, Aug 6, 2020 at 1:34 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pramod,
The patch looks good to me except:
1) Remove commented code.
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
3) Add the new coverage directory to .gitignore.
On Thu, Aug 6, 2020 at 4:59 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya
Please review it.
On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
Вложения
Thanks Aditya, made a note of this.
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Friday, 7 August 2020 at 10:34 AM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>, Dave Page <dpage@pgadmin.org>
Subject: Re: Code coverage report generation for JS files
Hi Pramod,
On Fri, Aug 7, 2020 at 10:05 AM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi Aditya,
As per your feedback, pleas find updates as below:
1) Remove commented code. Done
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
- Updated package.json for : "test:karma-coverage" & "test:karma-coverage-once"
Coverage in watch mode won't be used. Watch mode is useful when writing test cases. It would be run only once always. I suggest removing test:karma-coverage and rename test:karma-coverage-once to test:karma-coverage. Also, change the command to yarn run test:karma-once --reporters coverage,progress to avoid repetition.
@committer - please do the required change, no patch is required.
3) Add the new coverage directory to .gitignore. Done
Have attached patch with email.
The patch looks good to me.
Thanks you !
From: Dave Page <dpage@pgadmin.org>
Date: Thursday, 6 August 2020 at 6:18 PM
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: Pramod Ahire <pramod.ahire@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>
Subject: Re: Code coverage report generation for JS files
Hmm, this makes me think - if we have enough of the JS infrastructure on the SonarQube scanner server (which is easy to create in the Jenkins job), we could import the lcov reports into SonarQube.
On Thu, Aug 6, 2020 at 1:34 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pramod,
The patch looks good to me except:
1) Remove commented code.
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
3) Add the new coverage directory to .gitignore.
On Thu, Aug 6, 2020 at 4:59 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya
Please review it.
On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Вложения
Thanks Aditya, made a note of this.
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Friday, 7 August 2020 at 10:34 AM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>, Dave Page <dpage@pgadmin.org>
Subject: Re: Code coverage report generation for JS files
Hi Pramod,
On Fri, Aug 7, 2020 at 10:05 AM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi Aditya,
As per your feedback, pleas find updates as below:
1) Remove commented code. Done
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
- Updated package.json for : "test:karma-coverage" & "test:karma-coverage-once"Coverage in watch mode won't be used. Watch mode is useful when writing test cases. It would be run only once always. I suggest removing test:karma-coverage and rename test:karma-coverage-once to test:karma-coverage. Also, change the command to yarn run test:karma-once --reporters coverage,progress to avoid repetition.
@committer - please do the required change, no patch is required.
3) Add the new coverage directory to .gitignore. Done
Have attached patch with email.
The patch looks good to me.
Thanks you !
From: Dave Page <dpage@pgadmin.org>
Date: Thursday, 6 August 2020 at 6:18 PM
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: Pramod Ahire <pramod.ahire@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>
Subject: Re: Code coverage report generation for JS files
Hmm, this makes me think - if we have enough of the JS infrastructure on the SonarQube scanner server (which is easy to create in the Jenkins job), we could import the lcov reports into SonarQube.
On Thu, Aug 6, 2020 at 1:34 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pramod,
The patch looks good to me except:
1) Remove commented code.
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
3) Add the new coverage directory to .gitignore.
On Thu, Aug 6, 2020 at 4:59 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya
Please review it.
On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi,
Please find updated patch for below changes:
- Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
- Added exclusion expression for test cases
- Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
From: Pramod Ahire <pramod.ahire@enterprisedb.com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
- istanbul-instrumenter-loader
- karma-coverage
Steps to generate report:
- Apply attached patch
- Do - ‘npm install’
- Run – ‘yarn run test:karma’
It has below type of output formats supported:
- Html
- Lcov
- Cobertura
- Lcovonly
- Teamcity
- Text
- Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
--
Вложения
Thank you :)
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Friday, 7 August 2020 at 12:38 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Dave Page <dpage@pgadmin.org>
Subject: Re: Code coverage report generation for JS files
Thanks, patch applied.
Вложения
Thank you :)
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Friday, 7 August 2020 at 12:38 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Dave Page <dpage@pgadmin.org>
Subject: Re: Code coverage report generation for JS files
Thanks, patch applied.
Вложения
No Dave, the Makefile target was not added.
Have attached the patch for same, please do let me know if needed anything else.
@Akshay will you be able to review quickly on this ?
Thank you :)
From: Dave Page <dpage@pgadmin.org>
Date: Friday, 7 August 2020 at 2:16 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: Akshay Joshi <akshay.joshi@enterprisedb.com>, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>
Subject: Re: Code coverage report generation for JS files
Was a Makefile target added? Maybe "make coverage"...
On Fri, Aug 7, 2020 at 8:10 AM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Thank you :)
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Friday, 7 August 2020 at 12:38 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Dave Page <dpage@pgadmin.org>
Subject: Re: Code coverage report generation for JS files
Thanks, patch applied.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
Вложения
No Dave, the Makefile target was not added.
Have attached the patch for same, please do let me know if needed anything else.
@Akshay will you be able to review quickly on this ?
Thank you :)
From: Dave Page <dpage@pgadmin.org>
Date: Friday, 7 August 2020 at 2:16 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: Akshay Joshi <akshay.joshi@enterprisedb.com>, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>
Subject: Re: Code coverage report generation for JS files
Was a Makefile target added? Maybe "make coverage"...
On Fri, Aug 7, 2020 at 8:10 AM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Thank you :)
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Friday, 7 August 2020 at 12:38 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Dave Page <dpage@pgadmin.org>
Subject: Re: Code coverage report generation for JS files
Thanks, patch applied.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
--
Вложения
Thank you ! appreciates your quick action.
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Friday, 7 August 2020 at 5:25 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: Dave Page <dpage@pgadmin.org>, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>
Subject: Re: Code coverage report generation for JS files
Have attached the patch for same, please do let me know if needed anything else.