Обсуждение: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table

Поиск
Список
Период
Сортировка

[pgAdmin][RM4842] trigger/compound trigger on a partitioned table

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the patch to fix the issue where it was not possible to add constraints, index, rules, triggers and compound triggers on child tables of a partitioned table.
The problem was with URLs formed which also included parent table OID, which was not needed. The code is changed to add "url_jump_after_node" param to skip after a certain node, which will will skip all the value between jump_after_node to the last node, excluding jump_after_node and the last node. Partitioned table itself is a "table" and can be multilevel.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table

От
Akshay Joshi
Дата:
Hi Aditya

I have applied the patch and found one issue collection nodes are visible twice under the child node of the partition table. Please fix that.
Screenshot 2019-12-31 at 1.24.26 PM.png

On Wed, Dec 25, 2019 at 4:59 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the issue where it was not possible to add constraints, index, rules, triggers and compound triggers on child tables of a partitioned table.
The problem was with URLs formed which also included parent table OID, which was not needed. The code is changed to add "url_jump_after_node" param to skip after a certain node, which will will skip all the value between jump_after_node to the last node, excluding jump_after_node and the last node. Partitioned table itself is a "table" and can be multilevel.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Вложения

Re: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table

От
Aditya Toshniwal
Дата:
Hi Akshay,

On Tue, Dec 31, 2019 at 1:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

I have applied the patch and found one issue collection nodes are visible twice under the child node of the partition table. Please fix that.
I tried to simulate this. But I'm not facing issue. Can you please verify once again ? 
Screenshot 2019-12-31 at 1.24.26 PM.png

On Wed, Dec 25, 2019 at 4:59 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the issue where it was not possible to add constraints, index, rules, triggers and compound triggers on child tables of a partitioned table.
The problem was with URLs formed which also included parent table OID, which was not needed. The code is changed to add "url_jump_after_node" param to skip after a certain node, which will will skip all the value between jump_after_node to the last node, excluding jump_after_node and the last node. Partitioned table itself is a "table" and can be multilevel.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table

От
Akshay Joshi
Дата:
Hi Aditya

I have removed the generated folder and it works. Thanks, patch applied.

On Wed, Jan 1, 2020 at 11:58 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

On Tue, Dec 31, 2019 at 1:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

I have applied the patch and found one issue collection nodes are visible twice under the child node of the partition table. Please fix that.
I tried to simulate this. But I'm not facing issue. Can you please verify once again ? 
Screenshot 2019-12-31 at 1.24.26 PM.png

On Wed, Dec 25, 2019 at 4:59 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the issue where it was not possible to add constraints, index, rules, triggers and compound triggers on child tables of a partitioned table.
The problem was with URLs formed which also included parent table OID, which was not needed. The code is changed to add "url_jump_after_node" param to skip after a certain node, which will will skip all the value between jump_after_node to the last node, excluding jump_after_node and the last node. Partitioned table itself is a "table" and can be multilevel.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Вложения