Обсуждение: pgsql: Remove last traces of heap_open/close in the tree
Remove last traces of heap_open/close in the tree Since pluggable storage has been introduced, those two routines have been replaced by table_open/close, with some compatibility macros still present to allow extensions to compile correctly with v12. Some code paths using the old routines still remained, so replace them. Based on the discussion done, the consensus reached is that it is better to remove those compatibility macros so as nothing new uses the old routines, so remove also the compatibility macros. Discussion: https://postgr.es/m/20191017014706.GF5605@paquier.xyz Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f25968c49697db673f6cd2a07b3f7626779f1827 Modified Files -------------- src/backend/commands/statscmds.c | 4 ++-- src/backend/optimizer/util/plancat.c | 4 ++-- src/include/access/table.h | 10 ---------- 3 files changed, 4 insertions(+), 14 deletions(-)
On Sat, Oct 19, 2019 at 02:25:46AM +0000, Michael Paquier wrote: > Remove last traces of heap_open/close in the tree > > Since pluggable storage has been introduced, those two routines have > been replaced by table_open/close, with some compatibility macros still > present to allow extensions to compile correctly with v12. > > Some code paths using the old routines still remained, so replace them. > Based on the discussion done, the consensus reached is that it is better > to remove those compatibility macros so as nothing new uses the old > routines, so remove also the compatibility macros. > > Discussion: https://postgr.es/m/20191017014706.GF5605@paquier.xyz This has been causing failures with redis_fdw: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-10-19%2016%3A47%3A35 Thanks Andrew for the fix! https://github.com/pg-redis-fdw/redis_fdw/commit/2bfde6e56a7b4fe54ce3ee1f9b001bc75cadb60d -- Michael