Обсуждение: pgsql: pgbench: add --partitions and --partition-method options.

Поиск
Список
Период
Сортировка

pgsql: pgbench: add --partitions and --partition-method options.

От
Amit Kapila
Дата:
pgbench: add --partitions and --partition-method options.

These new options allow users to partition the pgbench_accounts table by
specifying the number of partitions and partitioning method.  The values
allowed for partitioning method are range and hash.

This feature allows users to measure the overhead of partitioning if any.

Author: Fabien COELHO
Reviewed-by: Amit Kapila, Amit Langote, Dilip Kumar, Asif Rehman, and
Alvaro Herrera
Discussion: https://postgr.es/m/alpine.DEB.2.21.1907230826190.7008@lancre

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b1c1aa53182372e907f3f7f090e7eb5f432a4c9a

Modified Files
--------------
doc/src/sgml/ref/pgbench.sgml                |  25 +++
src/bin/pgbench/pgbench.c                    | 306 +++++++++++++++++++++++----
src/bin/pgbench/t/001_pgbench_with_server.pl |  20 +-
src/bin/pgbench/t/002_pgbench_no_server.pl   |   7 +
4 files changed, 320 insertions(+), 38 deletions(-)


Re: pgsql: pgbench: add --partitions and --partition-method options.

От
Amit Kapila
Дата:
On Thu, Oct 3, 2019 at 8:33 AM Amit Kapila <akapila@postgresql.org> wrote:
pgbench: add --partitions and --partition-method options.


After this commit, I noticed fairywren is failing [1] with below symptoms:

pg_regress/strings LOG: statement: SELECT CAST(f1 AS char(10)) AS "char(text)" FROM TEXT_TBL;
2019-10-03 05:36:00.373 UTC [24272:43] LOG: server process (PID 23756) was terminated by exception 0xC0000028
2019-10-03 05:36:00.373 UTC [24272:44] DETAIL: Failed process was running: INSERT INTO INTERVAL_TBL (f1) VALUES ('badly formatted interval');
2019-10-03 05:36:00.373 UTC [24272:45] HINT: See C include file "ntstatus.h" for a description of the hexadecimal value.
2019-10-03 05:36:00.373 UTC [24272:46] LOG: terminating any other active server processes 2

On quick googling, it seems exception 0xC0000028 is related to windows stack corruption or something like that.   I don't think it is related to this patch.  It is also not clear that postgres code is at fault for this, so, let's wait for another run and see if it fails again.



--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Re: pgsql: pgbench: add --partitions and --partition-method options.

От
Amit Kapila
Дата:
On Thu, Oct 3, 2019 at 3:08 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Thu, Oct 3, 2019 at 8:33 AM Amit Kapila <akapila@postgresql.org> wrote:
pgbench: add --partitions and --partition-method options.


After this commit, I noticed fairywren is failing [1] with below symptoms:

pg_regress/strings LOG: statement: SELECT CAST(f1 AS char(10)) AS "char(text)" FROM TEXT_TBL;
2019-10-03 05:36:00.373 UTC [24272:43] LOG: server process (PID 23756) was terminated by exception 0xC0000028
2019-10-03 05:36:00.373 UTC [24272:44] DETAIL: Failed process was running: INSERT INTO INTERVAL_TBL (f1) VALUES ('badly formatted interval');
2019-10-03 05:36:00.373 UTC [24272:45] HINT: See C include file "ntstatus.h" for a description of the hexadecimal value.
2019-10-03 05:36:00.373 UTC [24272:46] LOG: terminating any other active server processes 2

On quick googling, it seems exception 0xC0000028 is related to windows stack corruption or something like that.   I don't think it is related to this patch.  It is also not clear that postgres code is at fault for this, so, let's wait for another run and see if it fails again.


Andrew has started a new thread to discuss this problem [1].  It has nothing to do with this patch, so let's discuss it there.


--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com