Обсуждение: A comment fix in xlogreader.c

While rechecking another patch, I found that 709d003fbd forgot to
edit a comment mentioning three members removed from
XLogReaderState.

See the attached.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c
index 27c27303d6..c8b0d2303d 100644
--- a/src/backend/access/transam/xlogreader.c
+++ b/src/backend/access/transam/xlogreader.c
@@ -103,8 +103,7 @@ XLogReaderAllocate(int wal_segment_size, const char *waldir,
     state->read_page = pagereadfunc;
     /* system_identifier initialized to zeroes above */
     state->private_data = private_data;
-    /* ReadRecPtr and EndRecPtr initialized to zeroes above */
-    /* readSegNo, readOff, readLen, readPageTLI initialized to zeroes above */
+    /* ReadRecPtr, EndRecPtr and readLen initialized to zeroes above */
     state->errormsg_buf = palloc_extended(MAX_ERRORMSG_LEN + 1,
                                           MCXT_ALLOC_NO_OOM);
     if (!state->errormsg_buf)

On Thu, Sep 26, 2019 at 11:08:09AM +0900, Kyotaro Horiguchi wrote:
> While rechecking another patch, I found that 709d003fbd forgot to
> edit a comment mentioning three members removed from
> XLogReaderState.
>
@@ -103,8 +103,7 @@ XLogReaderAllocate(int wal_segment_size, const char *waldir,
     state->read_page = pagereadfunc;
     /* system_identifier initialized to zeroes above */
     state->private_data = private_data;
-    /* ReadRecPtr and EndRecPtr initialized to zeroes above */
-    /* readSegNo, readOff, readLen, readPageTLI initialized to zeroes above */
+    /* ReadRecPtr, EndRecPtr and readLen initialized to zeroes above */
     state->errormsg_buf = palloc_extended(MAX_ERRORMSG_LEN + 1,
                                           MCXT_ALLOC_NO_OOM);
     if (!state->errormsg_buf)

I see.  readSegNo and readOff have been moved to WALOpenSegment and
replaced by new, equivalent fields, still all those three fields are
still initialized for the palloc_extended() call to allocate
XLogReaderState, while the two others are now part of
WALOpenSegmentInit().  Your change is correct, so applied.
--
Michael

At Thu, 26 Sep 2019 11:57:59 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20190926025759.GB2115@paquier.xyz>
> On Thu, Sep 26, 2019 at 11:08:09AM +0900, Kyotaro Horiguchi wrote:
> > While rechecking another patch, I found that 709d003fbd forgot to
> > edit a comment mentioning three members removed from
> > XLogReaderState.
> >
> @@ -103,8 +103,7 @@ XLogReaderAllocate(int wal_segment_size, const char *waldir,
>      state->read_page = pagereadfunc;
>      /* system_identifier initialized to zeroes above */
>      state->private_data = private_data;
> -    /* ReadRecPtr and EndRecPtr initialized to zeroes above */
> -    /* readSegNo, readOff, readLen, readPageTLI initialized to zeroes above */
> +    /* ReadRecPtr, EndRecPtr and readLen initialized to zeroes above */
>      state->errormsg_buf = palloc_extended(MAX_ERRORMSG_LEN + 1,
>                                            MCXT_ALLOC_NO_OOM);
>      if (!state->errormsg_buf)
> 
> I see.  readSegNo and readOff have been moved to WALOpenSegment and
> replaced by new, equivalent fields, still all those three fields are
> still initialized for the palloc_extended() call to allocate
> XLogReaderState, while the two others are now part of
> WALOpenSegmentInit().  Your change is correct, so applied.

Exactly. Thanks!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center