Обсуждение: Improve base backup protocol documentation

Поиск
Список
Период
Сортировка

Improve base backup protocol documentation

От
Peter Eisentraut
Дата:
It was apparently entirely undocumented that the tablespace size
estimates sent by the base backup protocol are in kilobytes.  Here is a
patch to document that.  Also, a related clarification in the
pg_basebackup.c source code: It was not clear without analyzing the
whole stack that "totalsize" is in kilobytes and "totaldone" is in bytes.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Вложения

Re: Improve base backup protocol documentation

От
Magnus Hagander
Дата:
On Wed, Aug 28, 2019 at 4:58 PM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
It was apparently entirely undocumented that the tablespace size
estimates sent by the base backup protocol are in kilobytes.  Here is a
patch to document that.  Also, a related clarification in the
pg_basebackup.c source code: It was not clear without analyzing the
whole stack that "totalsize" is in kilobytes and "totaldone" is in bytes.


+1, these both look like reasonable changes to me.

//Magnus
 

Re: Improve base backup protocol documentation

От
Peter Eisentraut
Дата:
On 2019-09-03 09:50, Magnus Hagander wrote:
> On Wed, Aug 28, 2019 at 4:58 PM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com
> <mailto:peter.eisentraut@2ndquadrant.com>> wrote:
> 
>     It was apparently entirely undocumented that the tablespace size
>     estimates sent by the base backup protocol are in kilobytes.  Here is a
>     patch to document that.  Also, a related clarification in the
>     pg_basebackup.c source code: It was not clear without analyzing the
>     whole stack that "totalsize" is in kilobytes and "totaldone" is in
>     bytes.
> 
> 
> +1, these both look like reasonable changes to me.

committed


-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services