Обсуждение: Obsolete comment in commands/analyze.c

Hi,

I think commit 83e176ec1, which moved block sampling functions to
utils/misc/sampling.c, forgot to update this comment in
commands/analyze.c: "This algorithm is from Jeff Vitter's paper (see
full citation below)"; since the citation was also moved to
utils/misc/sampling.c, I think the "see full citation below" part
should be updated accordingly.  Attached is a patch for that.

Best regards,
Etsuro Fujita

> On 27 Jun 2019, at 13:05, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:

> since the citation was also moved to
> utils/misc/sampling.c, I think the "see full citation below" part
> should be updated accordingly.  Attached is a patch for that.

Agreed, nice catch!

cheers ./daniel

On Thu, Jun 27, 2019 at 01:53:52PM +0200, Daniel Gustafsson wrote:
>> On 27 Jun 2019, at 13:05, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>
>> since the citation was also moved to
>> utils/misc/sampling.c, I think the "see full citation below" part
>> should be updated accordingly.  Attached is a patch for that.
>
>Agreed, nice catch!
>

Thanks, committed.


cheers

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On Fri, Jun 28, 2019 at 1:02 AM Tomas Vondra
<tomas.vondra@2ndquadrant.com> wrote:
> On Thu, Jun 27, 2019 at 01:53:52PM +0200, Daniel Gustafsson wrote:
> >> On 27 Jun 2019, at 13:05, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> >
> >> since the citation was also moved to
> >> utils/misc/sampling.c, I think the "see full citation below" part
> >> should be updated accordingly.  Attached is a patch for that.
> >
> >Agreed, nice catch!
>
> Thanks, committed.

Thanks for committing, Tomas!  Thanks for reviewing, Daniel!

Best regards,
Etsuro Fujita