Обсуждение: Removal of duplicate variable declarations in fe-connect.c

Поиск
Список
Период
Сортировка

Removal of duplicate variable declarations in fe-connect.c

От
Haribabu Kommi
Дата:
Hi Hackers,

During the development of another feature, I found that same local variables are declared twice.
IMO, there is no need of again declaring the local variables. Patch attached.

Regards,
Haribabu Kommi
Fujitsu Australia
Вложения

Re: Removal of duplicate variable declarations in fe-connect.c

От
Michael Paquier
Дата:
On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
> During the development of another feature, I found that same local
> variables are declared twice.
> IMO, there is no need of again declaring the local variables. Patch
> attached.

Indeed, fixed.  That's not a good practice, and each variable is
assigned in its own block before getting used, so there is no
overlap.
--
Michael
Вложения

Re: Removal of duplicate variable declarations in fe-connect.c

От
Haribabu Kommi
Дата:
On Fri, Feb 22, 2019 at 3:22 PM Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
> During the development of another feature, I found that same local
> variables are declared twice.
> IMO, there is no need of again declaring the local variables. Patch
> attached.

Indeed, fixed.  That's not a good practice, and each variable is
assigned in its own block before getting used, so there is no
overlap.

Thanks.

Regards,
Haribabu Kommi
Fujitsu Australia