Обсуждение: Possibly redundant context switch in postgres_fdw

Поиск
Список
Период
Сортировка

Possibly redundant context switch in postgres_fdw

От
Ildar Musin
Дата:
Hi hackers,

ISTM that context switch in `create_cursor()`:

if (numParams > 0)
{
MemoryContext oldcontext;
oldcontext = MemoryContextSwitchTo(econtext->ecxt_per_tuple_memory);
process_query_params(econtext,
fsstate->param_flinfo,
fsstate->param_exprs,
values);
MemoryContextSwitchTo(oldcontext);
}

is redundant since we should already be in `ecxt_per_tuple_memory` context according to `ForeignNext()`. Do I miss some hidden purpose? If not here is a patch that removes it.

Regards,
Ildar Musin
Вложения