Comment refers to non existent function IncreaseRestartDecodingForSlot

От:

Dave Cramer <davecramer@gmail.com>

Дата:

29 июня 2018 г. в 21:55:02

While trying to figure out this code I found

https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/replication/logical/logical.c;h=61588d626f608006196c769ad9807f1d3ac592e9;hb=HEAD#l913

What function should it be referring to ?

Thanks,

Dave Cramer

Re: Comment refers to non existent function IncreaseRestartDecodingForSlot

От:

Euler Taveira <euler@timbira.com.br>

Дата:

29 июня 2018 г. в 23:34:21

2018-06-29 15:55 GMT-03:00 Dave Cramer :
> While trying to figure out this code I found
>
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/replication/logical/logical.c;h=61588d626f608006196c769ad9807f1d3ac592e9;hb=HEAD#l913
>
> What function should it be referring to ?
>
LogicalIncreaseXminForSlot (it is a few lines above). It has been like
that since logical decoding was introduced. The trivial patch fixes
it.


-- 
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: Comment refers to non existent functionIncreaseRestartDecodingForSlot

От:

Michael Paquier <michael@paquier.xyz>

Дата:

2 июля 2018 г. в 07:32:45

On Fri, Jun 29, 2018 at 05:34:21PM -0300, Euler Taveira wrote:
> LogicalIncreaseXminForSlot (it is a few lines above). It has been like
> that since logical decoding was introduced. The trivial patch fixes
> it.

That looks right to me.  Pushed.
--
Michael