postgresql 11 release notes

Поиск
Список
Период
Сортировка
Искать

postgresql 11 release notes

От:
Brad DeJong <bpd0018@gmail.com>
Дата:
Вложения:
The diff is for release-11.sgml.

I fixed typos and grammar + rephrased some things that didn't seem to flow

The only major change is the section on PSQL_PAGER.

In the section on the new --create-slot option for pg_basebackup, it seems like <option>--slot</option> should include the =slotname part but I don't know the DocBook markup for that (maybe <replaceable>?).

I did not build the documentation after making my changes so the patch definitely needs to be sanity checked.

Thanks.


Re: postgresql 11 release notes

От:
Brad DeJong <bpd0018@gmail.com>
Дата:
Вложения:
same patch but renamed to match the patch file naming convention

On Thu, Jun 14, 2018 at 6:13 PM, Brad DeJong <bpd0018@gmail.com> wrote:
The diff is for release-11.sgml.

I fixed typos and grammar + rephrased some things that didn't seem to flow

The only major change is the section on PSQL_PAGER.

In the section on the new --create-slot option for pg_basebackup, it seems like <option>--slot</option> should include the =slotname part but I don't know the DocBook markup for that (maybe <replaceable>?).

I did not build the documentation after making my changes so the patch definitely needs to be sanity checked.

Thanks.



Re: postgresql 11 release notes

От:
Euler Taveira <euler@timbira.com.br>
Дата:
2018-06-15 7:58 GMT-03:00 Brad DeJong :
> same patch but renamed to match the patch file naming convention
>
Comments above:

        
-        Previously super users were exclusively granted to access these
+        Previously, super-users were exclusively granted access to these
         functions.
        

The terminology used in the documentation is "superuser".

        
         The new unit is "B".  This is in addition to "kB", "MB", "GB"
-        and "TB", which were accepted previously.
+        and "TB", which are already allowed.
        

I would replace only "were" by "are": "which are accepted previously".

        
-        Exclude unlogged, temporary tables, and
+        Exclude unlogged, temporary tables and
         pg_internal.init files from streaming base
         backups (David Steele)
        

AFAIK postgres uses Oxford comma a lot.

        
         Also, if any table mentioned in VACUUM uses
-        a column list, then ANALYZE keyword must be
-        supplied;  previously ANALYZE was implied in
+        a column list, then the ANALYZE keyword must be
+        supplied. Previously, ANALYZE was implied in
         such cases.
        

I prefer to maintain semicolon and add a comma after "previously".

        
-        This allows psql's default pager to
-        be specified as a separate environment variable from the pager
-        for other applications.  PAGER is still honored
-        if PSQL_PAGER is not set.
+        In addition to psql, other applications
+        use the PAGER environment variable. Having
+        PSQL_PAGER as a separate environment variable allows
+        you to use one pager for those applications and a different pager
+        for psql. psql
+        will still honor PAGER if PSQL_PAGER
+        is not set.
        

I don't see this as an improvement.

        
-        Add ability to suppress dumping and restoring of comments
+        Add an option to suppress dumping and restoring of comments
         (Robins Tharakan)
        

I would suggest "Add an option to suppress dumping and restoring comments".


-- 
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: postgresql 11 release notes

От:
Euler Taveira <euler@timbira.com.br>
Дата:
Brad, your forgot to reply to pgsql-docs.

2018-06-19 20:21 GMT-03:00 Brad DeJong :
> How about dropping the which clause entirely? I split this off as
> release-11-newunit-v1.patch for further discussion.
>
Works for me. Could you append it to v2?

>>         
>> -        Exclude unlogged, temporary tables, and
>> +        Exclude unlogged, temporary tables and
>>          pg_internal.init files from streaming base
>>          backups (David Steele)
>>         
>>
>> AFAIK postgres uses Oxford comma a lot.
>
> I left this change in the v2 patch.
> I didn't remove it because it was an Oxford comma; I removed it because
> there are only two items, tables and files, so this should not be a comma
> separated list.
> Unlogged and temporary both modify tables and tell us what kind of tables
> are being excluded.
> If this was a list, the items should be semi-colon separated because of the
> comma between unlogged and temporary.
> For example - Exclude unlogged, temporary tables; b-tree indexes; and
> pg_internal.init files from streaming base backups.
>
I see. I think the sentence should be "Exclude unlogged tables,
temporary tables, and pg_internal.init files from
streaming base backups".


-- 
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: postgresql 11 release notes

От:
Brad DeJong <bpd0018@gmail.com>
Дата:
Вложения:


On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira <euler@timbira.com.br> wrote:
Brad, your forgot to reply to pgsql-docs.

2018-06-19 20:21 GMT-03:00 Brad DeJong <bpd0018@gmail.com>:
> How about dropping the which clause entirely? I split this off as
> release-11-newunit-v1.patch for further discussion.
>
Works for me. Could you append it to v2?

Done. 
>>         <para>
>> -        Exclude unlogged, temporary tables, and
>> +        Exclude unlogged, temporary tables and
>>          <filename>pg_internal.init</filename> files from streaming base
>>          backups (David Steele)
>>         </para>
>>
>> AFAIK postgres uses Oxford comma a lot.
>
> I left this change in the v2 patch.
> I didn't remove it because it was an Oxford comma; I removed it because
> there are only two items, tables and files, so this should not be a comma
> separated list.
> Unlogged and temporary both modify tables and tell us what kind of tables
> are being excluded.
> If this was a list, the items should be semi-colon separated because of the
> comma between unlogged and temporary.
> For example - Exclude unlogged, temporary tables; b-tree indexes; and
> pg_internal.init files from streaming base backups.
>
I see. I think the sentence should be "Exclude unlogged tables,
temporary tables, and <filename>pg_internal.init</filename> files from
streaming base backups".

I like it. Done. 

--
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: postgresql 11 release notes

От:
Brad DeJong <bpd0018@gmail.com>
Дата:


On Thu, Jun 21, 2018 at 5:08 AM, Brad DeJong <bpd0018@gmail.com> wrote:


On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira <euler@timbira.com.br> wrote:
I see. I think the sentence should be "Exclude unlogged tables,
temporary tables, and <filename>pg_internal.init</filename> files from
streaming base backups".

I like it. Done. 


Just to make the difference explicit

"Exclude unlogged, temporary tables and ..." 
=> if (table.unlogged == true AND table.temporary == true) then exclude table

"Exclude unlogged tables, temporary tables, and ..."
=> if (table.unlogged == true OR table.temporary == true) then exclude table

I do not know whether the condition is an AND or an OR.
When you said "I think the sentence should be ...", I took that to mean that you know that the condition should be an OR.

Re: postgresql 11 release notes

От:
Euler Taveira <euler@timbira.com.br>
Дата:
2018-06-21 8:01 GMT-03:00 Brad DeJong :
> When you said "I think the sentence should be ...", I took that to mean that
> you know that the condition should be an OR.
>
There are separate conditions in the code (each one was done in
separate commits).


-- 
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: postgresql 11 release notes

От:
Bruce Momjian <bruce@momjian.us>
Дата:
On Thu, Jun 21, 2018 at 05:08:39AM -0500, Brad DeJong wrote:
> On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira  wrote:
>     > I left this change in the v2 patch.
>     > I didn't remove it because it was an Oxford comma; I removed it because
>     > there are only two items, tables and files, so this should not be a comma
>     > separated list.
>     > Unlogged and temporary both modify tables and tell us what kind of tables
>     > are being excluded.
>     > If this was a list, the items should be semi-colon separated because of
>     the
>     > comma between unlogged and temporary.
>     > For example - Exclude unlogged, temporary tables; b-tree indexes; and
>     > pg_internal.init files from streaming base backups.
>     >
>     I see. I think the sentence should be "Exclude unlogged tables,
>     temporary tables, and pg_internal.init files from
>     streaming base backups".
> 
> 
> I like it. Done. 

Patch applied.  This was a great help, thanks.  The "This features" typo
was already found.  I did not apply this part since it would have added
whitespace after the period.

> -        Add  -        linkend="pg-stat-activity-view">pg_stat_activity.backend_type
> +        pg_stat_activity.
> +        backend_type

-- 
  Bruce Momjian          http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

FAQ